Repository navigation
feat(features): Type frontend gates with scoped contracts - #129484
Draft
natemoo-re wants to merge 1 commit into
Draft
natemoo-re wants to merge 1 commit into
natemoo-re wants to merge 1 commit into
Conversation
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-nffwa0hr5.sentry.dev |
natemoo-re
force-pushed
the
feat/typed-feature-flags
branch
from
November 2, 2026 17:40
10a0f5c to
034a0e4
Compare
natemoo-re
changed the title
Contributor
Sentry Snapshot Testing
|
natemoo-re
force-pushed
the
feat/typed-feature-flags
branch
from
November 2, 2026 18:26
034a0e4 to
d4e7587
Compare
natemoo-re
changed the title
natemoo-re
changed the base branch from
feat/typed-feature-flags-backend
to
nm/features/retired-gates
November 2, 2026 18:28
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
natemoo-re
force-pushed
the
feat/typed-feature-flags
branch
from
November 2, 2026 18:35
d4e7587 to
a8a3135
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type organization, project, and global feature checks so typos and surviving consumers of removed public registrations fail typecheck. Public names come from #129478; private names already used by the public frontend stay in a small, manually maintained declaration.
Backend changes regenerate the public types before checking consumers. Ordinary frontend changes use the committed snapshot. Private flag removal remains a manual cleanup step, and local developer overrides continue to accept arbitrary names while validating stored boolean values.
Review the scoped types and override boundary first. Most remaining edits preserve literal types in wrappers and fixtures. Retired-feature behavior changes are in #129514, which this PR builds on.