Repository navigation
ref(flags): Remove preprod-size-analysis-pr-comments registration - #129454
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Reads are removed in #129452 and #129453, and the automator value in getsentry/sentry-options-automator#10416. Merge this last. Co-authored-by: charlie.luo <charlie.luo@sentry.io>
github-actions
Bot
added
the
Scope: Backend
This was referenced Nov 1, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
@getsentry/emerge-tools — stale feature flag cleanup for organizations:preprod-size-analysis-pr-comments, 4 of 4. Merge this one last.
Merge order:
- #129452 — frontend gate
- #129453 — backend reads
- getsentry/sentry-options-automator#10416 — the flagpole value
- #129454 (this one) — the
temporary.pyregistration
Nothing validates flagpole.yaml against registrations, so unregistering before the automator value is gone would leave that YAML block orphaned with no way to notice.
Two expected failures while this sits on top of today's master:
- The backend shard running
tests/sentry/preprod/vcs/pr_comments/test_size_tasks.py(and theBackendaggregate that rolls it up). That file still carries@with_feature(...)andself.feature({...: False})onmaster, and the testutilsFeaturehelper raisesValueError: Unregistered feature flagfor a name that is no longer registered. It clears as soon as #129453 merges. Blast radius is one shard, since that is the only test file touching the flag. getsentry dispatch, which gates on the author having write permission; the author iscursor[bot]. A collaborator needs to add theTrigger: getsentry testslabel.
Since api_expose=True, this also stops emitting the flag in organization.features, which is the other reason #129452 should land first.
Sent by Cursor Automation: Feature flag cleanup
Contributor
Backend Test FailuresFailures on
|
Contributor
Author
There was a problem hiding this comment.
CI finished and matches the prediction exactly — 76 green / 15 skipped / 1 neutral / 3 red, where the three reds are backend test (13), the Backend aggregate that rolls it up, and getsentry dispatch.
backend test (13) (shard 14 of 30, which runs tests/sentry/preprod/vcs/pr_comments/test_size_tasks.py) fails with:
ValueError: ('Unregistered feature flag: %s', "'organizations:preprod-size-analysis-pr-comments'")
raised from features_override in src/sentry/testutils/helpers/features.py, because that test file still carries @with_feature(...) on master. It clears the moment #129453 merges; there is nothing to fix here. Marking ready for review, but please keep it last in the merge order.
Status of the other three, all now out of draft:
- #129452 (frontend gate) — 51 green, only
getsentry dispatchred - #129453 (backend reads) — 49 green, only
getsentry dispatchred - getsentry/sentry-options-automator#10416 (flagpole) — 14 green / 2 skipped / 0 red, and its evaluation matrix reports only
Removed: feature.organizations:preprod-size-analysis-pr-commentswith no result-changing rows
Sent by Cursor Automation: Feature flag cleanup
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
organizations:preprod-size-analysis-pr-commentsfromtemporary.py. The flag reached GA in the automator in #8928 on 8/3/26 (conditions: [],rollout: 100) and hasn't been touched since.Merge this last. Order: #129452 (frontend reads) → #129453 (backend reads) → sentry-options-automator#10416 (flagpole value) → this. Nothing validates
flagpole.yamlagainst registrations, so unregistering before the automator value is gone would orphan the YAML block.Expected CI: red on the backend shard that runs
tests/sentry/preprod/vcs/pr_comments/test_size_tasks.py, plus theBackendaggregate. That file still carries@with_feature(...)andself.feature({...: False})onmaster, and the testutilsFeaturehelper raisesValueError: Unregistered feature flagfor an unregistered name. It clears once #129453 merges. Also expectgetsentry dispatchto fail — it gates on the author having write permission, and the author here iscursor[bot]; a collaborator needs to add theTrigger: getsentry testslabel.Stale flag cleanup; flagged by the feature-flag scanner as
ga-ready-to-graduate.