Repository navigation
fix(events-stats): Return 400 for EAP topEvents without a group-by - #129446
Open
1AbdullahButt wants to merge 1 commit into
Open
1AbdullahButt wants to merge 1 commit into
1AbdullahButt wants to merge 1 commit into
Conversation
A topEvents request on an RPC dataset (spans, logs, trace metrics) with only aggregate fields has no columns to group by. The top events conditions were then built from empty OR filters, which Snuba rejects, so the endpoint returned a 500 with no useful detail. Reject these requests up front with a 400 that says a non-aggregate field is needed, matching the existing "Cannot group by timestamp" check. Fixes getsentry#129342 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
topEventsrequest toevents-statson an EAP dataset (spans, logs, trace metrics) that has only aggregatefields, such asfield=p95(span.duration)&topEvents=10, has nothing to group by.build_top_event_conditionsthen builds an emptyOrFilterfor each top row, Snuba rejects it withInvalid trace item filter, empty 'or' clause, and the client gets a bare 500.This change checks for that case before running the RPC queries and returns a 400 with
topEvents requires at least one non-aggregate field. It sits next to the existingCannot group by timestampcheck, which handles another invalid group-by. Non-RPC datasets are unchanged.I added
test_top_events_without_groupbyto the spansevents-statstests. It sends the request shape from the issue and expects the 400. I couldn't run the Snuba-backed tests locally (no devservices on this machine), so I'm relying on CI for them.ruff formatandruff checkpass on the changed files.Fixes #129342
🤖 Generated with Claude Code
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.