Repository navigation
fix(issues): Exclude duplicate external issue actions from activity feed - #129439
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every external issue create/link action already emits an Activity row (
CREATE_ISSUE) which is mirrored into the action log and rendered asCreated/Linked {provider} issuein the feed.Serving the action-log-only
CREATE_EXTERNAL_ISSUE,LINK_EXTERNAL_ISSUE,CREATE_PLATFORM_EXTERNAL_ISSUE, andLINK_PLATFORM_EXTERNAL_ISSUEentries inget_serialized_activity_itemsintroduced duplicate items in the issue activity feed. Furthermore, because these action types have no Activity equivalent,GroupActionLogEntrySerializerserialized their type usingobj.get_type_display()as uppercase strings (e.g.CREATE_EXTERNAL_ISSUE), causing the frontendactivityItem()switch to fall through toSentry.captureMessagereportingUnknown group activity type: CREATE_EXTERNAL_ISSUE.Changes:
CREATE_EXTERNAL_ISSUE,LINK_EXTERNAL_ISSUE,CREATE_PLATFORM_EXTERNAL_ISSUE, andLINK_PLATFORM_EXTERNAL_ISSUEfrom the feed candidate queries and fallback check inget_serialized_activity_itemsviaFEED_EXCLUDED_ACTION_TYPES.obj.get_type_display().lower()), matching Activity serialization conventions so action-log-only types likeunlink_external_issuematch frontend enum values.tests/sentry/api/serializers/test_groupactionlogentry.pycovering serialization case, feed exclusion, and fallback behavior.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3FMR
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.