Repository navigation
Conversation
Thresholds are a JSONField, but unit and max_values were cast to their response types without validation. Reject non-object thresholds, unknown or non-integer maximum keys, and non-string units at write time so the serializer's casts are backed by a validated invariant.
github-actions
Bot
added
the
Scope: Backend
joshuarli
added a commit
to joshuarli/sentry
that referenced
this pull request
Oct 31, 2026
Reject non-object thresholds, unknown or non-integer maximum keys, and non-string units at write time so the serializer casts are backed by a validated invariant. Review split: getsentry#129434.
Keep the parametrized case table typed so the backend mypy run accepts the new test module.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavioral split from #129431 (cast audit).
Thresholds are stored in a
JSONFieldand the read serializer castsunittostrandmax_valuestodict[str, int]without checking the stored shape. Validate at write time:max_valuesmust be an object with onlymax1/max2keys, integer values, and increasing valuesunitmust be a stringThis makes the read-side casts backed by a validated invariant. Tests cover non-object thresholds, non-object
max_values, unknown keys, non-integer values, and non-string units.