Repository navigation
Conversation
The release archive manifest and artifact index are user-uploaded JSON. Validate that the decoded value is an object before treating it as one, so malformed input fails at the boundary instead of raising AttributeError deeper in the archive reader.
joshuarli
added a commit
to joshuarli/sentry
that referenced
this pull request
Oct 31, 2026
The release archive manifest and artifact index are user-uploaded JSON. Validate that the decoded value is an object before treating it as one, so malformed input fails at the boundary instead of raising AttributeError deeper in the archive reader. Review split: getsentry#129432.
github-actions
Bot
added
the
Scope: Backend
The manifest root is validated, but `files` still needs an object shape before it is counted and indexed. Reject non-object values at the archive boundary and cover both malformed shapes.
joshuarli
added a commit
to joshuarli/sentry
that referenced
this pull request
Oct 31, 2026
The manifest root is validated, but `files` still needs an object shape before it is counted and indexed. Reject non-object values at the archive boundary and cover both malformed shapes. Review split: getsentry#129432.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavioral split from #129431.
The release archive manifest and artifact index are user-uploaded JSON. The typing pass cast
json.loads()todict[str, object]without checking the decoded shape. Validate that the result is an object at the boundary, in_read_manifest,_ArtifactIndexGuard.readable_data, andwritable_data.A malformed manifest now raises
ValueErrorwith a clear message instead of failing later withAttributeErrororTypeError.Test:
test_manifest_must_be_a_json_object.