Skip to content

ref(typing): Let feature and search helpers take a service account - #129423

Draft
gricha wants to merge 1 commit into
ref/sa-narrow-api-bfrom
ref/sa-narrow-widen
Draft

gricha wants to merge 1 commit into
ref/sa-narrow-api-bfrom
ref/sa-narrow-widen

Conversation

@gricha

@gricha gricha commented Oct 31, 2026

Copy link
Copy Markdown
Member

is_provider_enabled, the preprod quota checks, investigation action kinds' cannot_apply_reasons, parse_user_value and store_issue_last_defaults now take a RequestPrincipal. They only forward the caller to features.has(), ignore it, or already check has_user(), so this is type-only.

4 files leave the request.user mypy allowlist (27 to 23).

`is_provider_enabled`, the preprod quota checks, investigation action kinds' `cannot_apply_reasons`, `parse_user_value` and `store_issue_last_defaults` now take a `RequestPrincipal`. They only forward the caller to `features.has()`, ignore it, or already check `has_user()`, so this is type-only.

4 files leave the `request.user` mypy allowlist (27 to 23).
@gricha
gricha added this pull request to stack #129364 October 31, 2026 02:27
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 31, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant