Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Backend
Contributor
Sentry Snapshot Testing
|
gricha
force-pushed
the
ref/sa-narrow-misc
branch
from
November 1, 2026 04:24
4c95fee to
71d23a5
Compare
…d investigations Flags, preprod, replays, releases, feedback, data export, data secrecy, investigations, workflow engine and superuser-middleware logging read the caller through `sentry.auth.principal`. - A service account can create flag webhook secrets and approve preprod artifacts (recorded with no creator/approver) and gets 404 for data exports it doesn't own; span stars, replay viewed-by and test-fire actions are 403 `user-required`. New tests cover the first three. - Token callers: no longer count as the creator of a flag secret with no creator (updating it now needs `org:write`), no longer treat a null-approver approval as their own, can't read null-user exports, and starring a span returns 401 instead of a 500. - Users and agents see no change. Left: `data_export.py` (`get_or_create` keyed on the user), `notebooks/base.py` (`user_id()` helper used by about 15 endpoints) and `web/client_config.py` (Django views typed as DRF requests).
gricha
force-pushed
the
ref/sa-narrow-misc
branch
from
November 1, 2026 04:57
71d23a5 to
6958b17
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags, preprod, replays, releases, feedback, data export, data secrecy, investigations, workflow engine and superuser-middleware logging read the caller through
sentry.auth.principal.user-required. New tests cover the first three.request.accessholds every scope, so it already passes theorg:writebranch, and a null-approver approval is still an approval.Left:
data_export.py(get_or_createkeyed on the user),notebooks/base.py(user_id()helper used by about 15 endpoints) andweb/client_config.py(Django views typed as DRF requests).