Repository navigation
Conversation
Issue endpoints (hashes, similar issues, notes, issue views, supergroups, release commits) read the caller through `sentry.auth.principal`; personal issue-view writes use `require_user()`. - A service account can unmerge (was a 500: `ServiceAccountId` isn't serializable) and gets 404 editing notes it doesn't own; posting a note and saving issue views stay 403 `user-required` by design. Seer no longer receives a service-account id as the user. New tests cover unmerge and notes. - Legacy API keys get 401 instead of a 500 on starred issue views. - Users and agents see no change. Left on the allowlist: issue search (`convert_query_values`, `parse_query`, `validate_search_filter_permissions`). Passing no user there makes `assigned:my_teams` resolve to an empty team list, and `assigned_to_filter([])` matches every issue: an existing bug for users with no teams and API keys, which needs fixing first. Also `get_create_issue_config` in `group_integration_details.py`.
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue endpoints (hashes, similar issues, notes, issue views, supergroups, release commits) read the caller through
sentry.auth.principal; personal issue-view writes userequire_user().ServiceAccountIdisn't serializable) and gets 404 editing notes it doesn't own; posting a note and saving issue views stay 403user-requiredby design. Seer no longer receives a service-account id as the user. New tests cover unmerge and notes.Left on the allowlist: issue search (
convert_query_values,parse_query,validate_search_filter_permissions). Passing no user there makesassigned:my_teamsresolve to an empty team list, andassigned_to_filter([])matches every issue: an existing bug for users with no teams and API keys, which needs fixing first. Alsoget_create_issue_configingroup_integration_details.py.mypy allowlist: 94 → 83 files.