Repository navigation
Conversation
…ndpoints Sentry app and integration endpoints read the caller through `sentry.auth.principal`: service lookups and analytics use `acting_user_id()` (analytics only record a user id when there is one), proxy-user and requester checks use `is_acting_user()`, and app create/delete/uninstall use `require_user()`. - A service account can use the coding-agents endpoint (no identity lookup with a service-account id); new test fails on the old code. The rest are control-silo, which service accounts don't reach yet. - Legacy API keys creating a Sentry app get 401 instead of a 500 from an `assert`. - Users and agents see no change. Left: `organization_config_integrations.py` (passes the caller to `is_provider_enabled`, widened higher in the stack).
github-actions
Bot
added
the
Scope: Backend
Contributor
Sentry Snapshot Testing
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry app and integration endpoints read the caller through
sentry.auth.principal: service lookups and analytics useacting_user_id()(analytics only record a user id when there is one), proxy-user and requester checks useis_acting_user(), and app create/delete/uninstall userequire_user().assert.Left:
organization_config_integrations.py(passes the caller tois_provider_enabled, widened higher in the stack).mypy allowlist: 126 → 117 files.