Repository navigation
ci(acceptance): experiment: 3 xdist workers with Chrome reuse - #129406
sentry-junior[bot] wants to merge 4 commits into
Conversation
… only on failure Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
execute_cdp_cmd exists only on the Chrome driver, so the reuse cache and reset helper take webdriver.Chrome. Popping the cache into its own local avoids the WebDriver type context rejecting the None default.
5eec128 to
dbfa71d
Compare
Experiment results (Arm, 5 acceptance shards)Acceptance test-step seconds per shard, from the GitHub Actions step timestamps:
Flakiness: all 4 Chrome-reuse runs had a rerun on shard 3, and 3 of them were Other checks: Backend, backend typing (after the fix on #129405/#129406), Cost: each job still spends about 2 minutes on setup, so job time drops less than test time. The job median goes from 286s to 275s (poll), 241–246s (reuse), and 237s (reuse + 3 workers). This PR (#129406): 3 workers saves another ~7–9% of test time and ~15–25s on the slowest shard compared with reuse alone, but it depends on Chrome reuse and has the same flake risk. Worth revisiting after reuse is deflaked. Closing as an experiment. |
Experiment stacked on #129387. Not meant to merge. I'll post timings and then close it.
It includes the
ci/acc-exp-pollandci/acc-exp-chrome-reusecommits and adds one change:XDIST_WORKERSinacceptance.ymlgoes from 2 to 3.On x64, 3 workers made no difference (test time −2%, within noise) and jobs were 5% longer. On Arm the runner is only about 67% busy during tests, so a third worker may help here, especially once per-test Chrome churn is gone.
via @joshuarli.
--
View Session [Sentry]