Repository navigation
[experiment] ci(backend): stop ClickHouse logging every test query - #129369
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
…test query Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
sentry-junior
Bot
added
Scope: Backend
Contributor
Author
|
Result: the setting didn't take effect for Snuba's queries. query_log still recorded about 23k rows per shard, probably because Snuba's connections were opened before the change. ClickHouse CPU went from 0.382 to 0.373 cores, which is noise. Making this work would need a ClickHouse restart before the per-worker bootstrap, and at most about 0.15 cores is in play. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. A stacked experiment on #129338 with 4 workers.
ClickHouse uses about 0.4 cores during tests. Its own queries account for a bit over half of that, about 8k per shard, mostly test-reset truncates and inserts. The rest is background work, including writing a log row and profiler samples for every query.
This adds a
users.dprofile that turns offlog_queries, processor profiles and the query profiler, then reloads the config. No restart is needed. A final step counts the query_log rows written, to show whether the setting reached the Snuba connections. Compare the ClickHouse CPU-seconds in the resource-usage artifacts against #129338.via @joshuarli.
--
View Session [Sentry]