[sentry-junior]

New number based filters (numeric, integer, currency, duration, size, percentage, and their aggregates) now start without a value, e.g. span.duration:>, instead of being pre-filled with 100, 10ms, 10bytes, etc. Previously the example value was committed into the query as soon as the filter was added, so results were filtered by a value the user never picked.

No grammar or API changes. Neither the frontend nor the backend grammar can write an empty number filter (key:> parses as an invalid text filter or free text in both). Instead of changing that, the builder keeps the incomplete filter out of the committed query:

• useQueryBuilderState tracks a pendingFilterKey. The draft query still holds the filter with its placeholder value, so the chip, operator menu and token-location logic work unchanged.
• While a filter is pending, committedQuery never includes it. onChange, onSearch and the API only see the filter once a value is entered or the user leaves the filter. Pressing Enter in the free text input searches the committed query while a filter is pending.
• The chip shows an empty value, the value input starts empty (the old default stays as the input placeholder), and the row label leaves the value out. If the operator changes to "is", the placeholder isn't treated as a selected value.
• The filter stays pending while the user changes its key, operator or aggregate arguments. None of these commit the query, so the previous search stays in place (no dangling OR from removing the pending filter), and changing the key or operator returns focus to the value. Closing the key editor without a change (same key, Escape, or an empty key) also returns focus to the value; only blurring it counts as leaving the filter.
• Leaving the filter without a value commits it with the placeholder value (e.g. span.duration:>10ms): Escape or Enter with an empty input, focus moving outside the filter, or blurring with an invalid value that gets rejected. Undo skips the pending state.
• The filter's remove (X) button and the search bar's "Clear search query" button act on pointer down while a filter is pending. Otherwise the press moves focus out of the filter first: the remove click could miss the button and leave an empty filter behind, and clearing committed the placeholder value and ran an extra search before the query was cleared. The remove button ignores the click that follows such a press, because the positional item key means the button is reused for the next filter.

Dashboard global filters call getInitialFilterText directly and are unchanged.

Things to look at:

• Pending is tracked by positional item key (filter:N). After each action the reducer finds the filter again by the unchanged text before or after it. That covers the normal flows, but I'd like a second look at it.
• Leaving the filter is detected with a deferred focus check, because the operator menu moves focus out of the chip and back.
• Specs that used {Escape} to accept the default value still pass as on master. Specs that check the chip right after adding a filter now expect an empty value.

via Nick.

--

View Session [Sentry]

[github-actions]

📊 Type Coverage Diff

✅ no issues found

[github-actions]

Story previews

Preview the stories changed in this PR on the Vercel deployment:

• app/components/searchQueryBuilder/index.stories.tsx

_{Preview deployment: https://sentry-54skx00tq.sentry.dev}

[nsdeschenes]

Closing out as this is a bloated implementation now. Gonna go with #129535 instead.