Repository navigation
feat(dashboards): Add trace metrics variants of the web vitals dashboards - #128924
Merged
edwardgou-sentry merged 27 commits intoNov 2, 2026
Merged
edwardgou-sentry merged 27 commits into
edwardgou-sentry merged 27 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
Contributor
📊 Type Coverage Diff
🔍 3 new type safety issues introducedNon-null assertions (
Type assertions (
This is informational only and does not block the PR. |
edwardgou-sentry
force-pushed
the
edwardgou-sentry/feat/dashboards-web-vitals-trace-metrics-config
branch
from
October 28, 2026 19:28
fb8daac to
ebd2c3e
Compare
…ware helper Lets a prebuilt config be swapped for a variant behind an org feature without touching every consumer.
…ards Served behind dashboards-web-vitals-trace-metrics. Samples and interactions stay on spans.
… of score formulas The trace metrics dataset has no performance_score or count_scores, so use avg and count. The pages table stays on spans.
edwardgou-sentry
force-pushed
the
edwardgou-sentry/feat/dashboards-web-vitals-trace-metrics-config
branch
from
October 28, 2026 19:35
ebd2c3e to
3aaea66
Compare
Drop the series label rework and extra tests the variants do not need.
Base automatically changed from
edwardgou-sentry/feat/dashboards-prebuilt-config-resolver
to
master
October 28, 2026 20:12
…ards Served behind dashboards-web-vitals-trace-metrics. Samples and interactions stay on spans.
… of score formulas The trace metrics dataset has no performance_score or count_scores, so use avg and count. The pages table stays on spans.
Drop the series label rework and extra tests the variants do not need.
edwardgou-sentry
force-pushed
the
edwardgou-sentry/feat/dashboards-web-vitals-trace-metrics-config
branch
from
October 28, 2026 20:12
2466842 to
c397de8
Compare
…cs-config' of github.com:getsentry/sentry into edwardgou-sentry/feat/dashboards-web-vitals-trace-metrics-config
…try/feat/dashboards-web-vitals-trace-metrics-config
Drops the local unit widening now that DataUnit knows about fractions.
edwardgou-sentry
changed the base branch from
master
to
edwardgou-sentry/feat/fraction-unit
October 30, 2026 22:09
…cs dashboards wait on
| const isScoreBreakdown = isWebVitalScoreBreakdownChart(widget.queries[queryIndex]!); | ||
| return transformTimeSeriesResponse( | ||
| isScoreBreakdown | ||
| ? transformPerformanceScoreBreakdownTimeSeries(data, webVitalScoreField) |
Contributor
Author
There was a problem hiding this comment.
This logic is copied over from the spans version path.
Applies a weight to each web vital score series. The end result is that the "area" of all the series together form the total score (maxed out at 100).
…ics dashboards Matches the spans dashboards. It fills in once Relay copies geo attributes onto the metrics.
| import {ModuleName} from 'sentry/views/insights/types'; | ||
|
|
||
| // TODO: Move these to trace metrics once the metrics can back them. | ||
| const SPANS_WIDGET_IDS = new Set([ |
Contributor
Author
There was a problem hiding this comment.
TODO: several charts still use the spans dataset for now until attributes are more complete on metrics and necessary score functions are added to metrics dataset. Those blockers are being worked on in parallel.
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9f1f71c. Configure here.
edwardgou-sentry
marked this pull request as ready for review
October 31, 2026 00:03
DominikB2014
approved these changes
Nov 2, 2026
Base automatically changed from
edwardgou-sentry/feat/fraction-unit
to
master
November 2, 2026 16:41
…entry/feat/dashboards-web-vitals-trace-metrics-config # Conflicts: # static/app/views/dashboards/datasetConfig/utils/traceMetricsResponseTransforms.ts
edwardgou-sentry
deleted the
edwardgou-sentry/feat/dashboards-web-vitals-trace-metrics-config
branch
November 2, 2026 17:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a trace metrics version of the Web Vitals prebuilt dashboards. These dashboards are meant to replicate the functionality of the existing spans backed Web Vitals dashboards, but with trace metrics data. This is a work in progress and some of the widgets defined here still remain on spans while we work on unblocking in metrics.
This version is behind feature flag and won't be shown to users yet.
Scores come from
browser.web_vital.<vital>.scoreratio metrics emitted from Relay.Leverages
FractionUnitfor the score metrics from the stacked pr (#129337).