Repository navigation
Conversation
BasePaginator.build_queryset assigned the reversed ordering to queryset.query.order_b, a typo for order_by, when the queryset was already ordered by the descending key and a previous-page cursor needed ascending order. The assignment was silently dropped, so the previous page was filtered as if ascending but still sorted descending, returning the wrong rows. The ordering is now written to order_by, matching the sibling branch.
github-actions
Bot
added
the
Scope: Backend
Exercise the branch that reverses an explicitly descending queryset for a previous-page cursor. Without the order_by fix, the previous page returns the current row instead of the preceding page.
This was referenced Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasePaginator.build_querysetreverses the queryset ordering when a previous-page cursor needs the opposite direction. In the branch where the queryset is already ordered by-keyand ascending order is needed, the result was assigned toqueryset.query.order_b, a typo fororder_by. The assignment only set a stray attribute, so the queryset stayed descending while the cursor filter was built for ascending order, and the previous page came back with the wrong rows. It now assignsorder_by, as the sibling branch above it does.The only affected callers are paginators whose queryset is already ordered by
-keyand that are asked for a previous page.Regression test:
test_prev_page_with_explicit_descending_querysetcovers an explicitly descending queryset and asserts the preceding page is returned. It fails on the typo and passes with the fix.