Upload screenshot snapshots to Sentry#5378
Open
runningcode wants to merge 2 commits intomainfrom
Open
Conversation
Replace local golden-image comparison in ScreenshotEventProcessorTest with Sentry Snapshots for visual diffing. Screenshots are now generated to build/test-snapshots/ and uploaded via sentry-cli in CI. - Remove local snapshot comparison logic and dropbox-differ dependency - Delete golden images from version control - Add sentry-cli install and upload steps to build.yml - Use PR head SHA checkout for correct base-vs-head diffing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2195398 | 319.02 ms | 342.38 ms | 23.36 ms |
| d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
| d15471f | 286.65 ms | 314.68 ms | 28.03 ms |
| ff8eea4 | 313.42 ms | 337.08 ms | 23.66 ms |
| 17a0955 | 372.53 ms | 446.70 ms | 74.17 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| cf708bd | 408.35 ms | 458.98 ms | 50.63 ms |
| 6edfca2 | 305.52 ms | 432.78 ms | 127.26 ms |
| 72020f8 | 312.32 ms | 370.94 ms | 58.62 ms |
| 6b019b7 | 343.31 ms | 417.23 ms | 73.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2195398 | 0 B | 0 B | 0 B |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| ff8eea4 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| 17a0955 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 6edfca2 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| 72020f8 | 1.58 MiB | 2.19 MiB | 620.21 KiB |
| 6b019b7 | 0 B | 0 B | 0 B |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing snapshot diffing logic in favor of uploading to sentry for diffing.
Note, we use the sentry-cli to upload and not SAGP because SAGP can only be applied to
com.android.applicationright now.Summary
ScreenshotEventProcessorTestwith Sentry Snapshots for visual diffingbuild/test-snapshots/during test runs and uploaded viasentry-cli build snapshotsin CIdropbox-differdependency and delete golden images from version control#skip-changelog
🤖 Generated with Claude Code