feat(logs): support for capture_* config#1077
Draft
solnic wants to merge 4 commits into
Draft
Conversation
solnic
force-pushed
the
feat/logs-capture-config
branch
2 times, most recently
from
fe54e9f to
d030abf
Compare
Collaborator
Author
|
@PJUllrich would that be a good solution in your case? 😄 |
Contributor
|
@solnic yes, I think so! Thank you! ❤️💚💛💜💙❤️ |
solnic
force-pushed
the
feat/logs-capture-config
branch
from
d030abf to
e071445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for configuring the log handler error capturing - which is different from sending error logs and crashes.
Two new options are added go
:logsconfig:capture_log_messages- toggle capturing on / offcapture_level- the log level for capturing (distinct fromlogs.levelconfig)capture_metadata- which metadata is accepted when capturing log messagescapture_excluded_domains- which logging domains must be excluded when capturing log messagesThis is the first step towards deprecating the original
Sentry.LoggerBackendasSentry.LoggerHandleris replacing it, handling both structured logging and capturing logs as Sentry events.Refs #1036