Skip to content

Reconcile publish issue after successful releases - #9824

Merged
BYK merged 2 commits into
mainfrom
fix/publish-success-checklist
Oct 9, 2026
Merged

BYK merged 2 commits into
mainfrom
fix/publish-success-checklist

Conversation

@BYK

@BYK BYK commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Reconcile the issue checklist after successful Craft publishing as well as after failure or cancellation, before closing it.
  • Preserve Craft’s final publish-state inode with a hard link: Craft writes each target in place and unlinks its state-file path on success. The updater reads the retained link, including after Craft deletes the original path.
  • Keep issue-bookkeeping errors from changing a successful publish into a failed one. Failure and cancellation still report their original outcome.

This fixes future releases; it does not edit closed issues such as #9822.

Validation

  • The success-path workflow regression failed before the condition change. Both Cursor regressions failed against the previous PR head and passed after the fix.
  • pnpm test --printConsoleTrace: 18 files, 151 passed.
  • pnpm exec eslint --no-eslintrc --config .eslintrc.js src .github --ignore-pattern '!.github' passed. Standard pnpm lint collides with the parent checkout’s duplicate ESLint plugin because this worktree sits inside it.
  • pnpm exec prettier --check src/modules/__tests__/publish-workflow.js .github/workflows/publish.yml passed.
  • No build or typecheck script is defined in this JavaScript repository.

@BYK
BYK requested a review from a team as a code owner October 9, 2026 09:03

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1a93e1b. Configure here.

Comment thread .github/workflows/publish.yml
Comment thread .github/workflows/publish.yml
@BYK
BYK merged commit f2573fe into main Oct 9, 2026
14 checks passed
@BYK
BYK deleted the fix/publish-success-checklist branch October 9, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant