Repository navigation
fix(changelog): Ignore #skip-changelog inside Markdown code - #952
Merged
Merged
Conversation
A commit or PR body that only quotes the magic word in a code span or fenced block no longer drops the change from the changelog and auto-versioning. The squash commit for #950 documented the bump commit's message in backticks, which skipped it and left the 3.7.0 release with no commits to version. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Contributor
|
BYK
requested changes
Nov 2, 2026
Replace the hand-rolled code fence and code span stripping with marked's lexer, which the changelog code already uses. Only prose and HTML tokens are checked, so code anywhere (including in lists and tables) is ignored while hidden HTML comments still count.
BYK
approved these changes
Nov 2, 2026
8 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip magic word was matched as a plain substring anywhere in a commit message or PR body. #950's squash commit described the post-release bump commit in backticks, so the feature dropped itself:
craft prepare autofound zero commits since 3.6.0 and the 3.7.0 release failed with "no commits found since the last release".Now mentions inside Markdown inline code spans (including ones hard-wrapped across lines, as in squash commits) and fenced code blocks are ignored. The word still works anywhere in plain prose, so the documented "anywhere in your commit message or PR body" behavior holds, and Craft's own
meta: Bump new development versioncommits are still skipped. Both checks (the early git commit-body filter andshouldExcludePRfor PR bodies) share the new helper.Once this merges, the next auto release will count #950 again (verified against its actual commit message), so a plain re-run should get 3.7.0 out with #950 in the changelog.
via @BYK.
--
View Session in Sentry