Repository navigation
feat(nuget): Scope workspace expansion to the selected release workspace - #940
Merged
Merged
Conversation
Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
Contributor
|
BYK
approved these changes
Oct 27, 2026
8 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #938. With a release workspace selected, a NuGet target with
workspaces: truestill expanded every packable project in the solution, so releasing one workspace would publish all of them.Expansion now keeps only the projects inside the selected workspace's directory. The solution is still read from the repository root, so
solutionPathkeeps its documented meaning, and auto-discovery still looks there. This matches getsentry/sentry-dotnet: a single rootSentry.slnxlistssrc/Sentry,src/Sentry.Maui, and so on, so asrc/Sentry.Mauiworkspace expands to justSentry.Maui. The new tests use the existingmsbuild-solutionfixture, which has the same layout.The workspace filter runs before
includeWorkspaces/excludeWorkspaces. If no packable project is inside the workspace, Craft fails with a configuration error. Workspaces that are not directories (aliases) and configs without workspaces behave as before.expandWorkspaceTargetspasses the release unit directory to every expandable target as a third argument. Only NuGet uses it for now; npm expansion does not change.via @BYK.
--
View Junior Session [Sentry]