Skip to content

fix(copyright): recover source comment action credits - #1419

Merged
mstykow merged 1 commit into
fix/contactless-chained-action-creditsfrom
fix/source-comment-action-credits
Sep 3, 2026
Merged

fix(copyright): recover source comment action credits#1419
mstykow merged 1 commit into
fix/contactless-chained-action-creditsfrom
fix/source-comment-action-credits

Conversation

@mstykow

@mstykow mstykow commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Normalize bounded DCL and VOS comment prefixes before evaluating explicit author actions.
  • Support date-qualified written by source-header credits.
  • Recover comma-delimited action-credit sentences embedded in source lines while requiring a person-shaped name.
  • Preserve those explicit attributions through the scanner guard for code-shaped spans.

Issues

Scope and exclusions

  • Included: explicit action credits in source comments and code-adjacent comment sentences.
  • Explicit exclusions: collective maintainer credits, handled in the next stacked layer.

How to verify

  • Scan Perl 5.38.4 with --copyright; vms/myconfig.com, vos/compile_full_perl.cm, and cpan/Win32API-File/Makefile.PL should report Peter Prymmer, Paul Green, and Alexandr Ciornii respectively.
  • Before/after corpus scans add exactly those three authors; Info-ZIP, musl, Dancer2, and Valgrind author output is unchanged, and copyright/holder output is unchanged across all five targets.

Intentional differences from Python

  • None for the three motivating credits; the implementation is evidence-bounded rather than mirroring ScanCode internals.

Follow-up work

  • Created or intentionally deferred: contactless collective maintainer credits and mixed author/copyright POD headings remain for the next stacked PR.

Expected-output fixture changes

  • Files changed: none.
  • Why the new expected output is correct: detector and scanner tests cover the new source-comment boundaries.

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow
mstykow force-pushed the fix/source-comment-action-credits branch from 6893b4a to fc0e16b Compare September 3, 2026 11:06
@mstykow

mstykow commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai review

@mstykow
mstykow merged commit 87c752d into main Sep 3, 2026
12 checks passed
@mstykow
mstykow deleted the fix/source-comment-action-credits branch September 3, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant