Skip to content

fix(copyright): recover chained action credits - #1418

Merged
mstykow merged 1 commit into
fix/narrative-author-attributionsfrom
fix/contactless-chained-action-credits
Sep 3, 2026
Merged

fix(copyright): recover chained action credits#1418
mstykow merged 1 commit into
fix/narrative-author-attributionsfrom
fix/contactless-chained-action-credits

Conversation

@mstykow

@mstykow mstykow commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Recover contactless people from explicit trailing action clauses such as modified by NAME.
  • Recover the first credited person from bounded subject is by NAME, modified by NAME chains.
  • Require person-shaped names so tool and generator subjects remain rejected.

Issues

Scope and exclusions

  • Included: line-local chained action attribution recovery.
  • Explicit exclusions: unrelated source-comment prefixes and collective maintainer attribution, which are separate follow-up layers.

How to verify

  • Scan Info-ZIP 3.0 with --copyright; win32/crc_i386.c should include Chr. Spieler, and amiga/stat.c should include both Paul Wells and Paul Kienitz.
  • The same before/after corpus scan leaves author output unchanged for Perl 5.38.4, musl, Dancer2, and Valgrind, and leaves copyright and holder output unchanged across all five targets.

Intentional differences from Python

  • Provenant additionally recovers Paul Wells from This stat() is by Paul Wells, modified by Paul Kienitz; ScanCode only reports the second person.

Follow-up work

  • Created or intentionally deferred: source-comment action credits and contactless collective maintainer credits will be handled in subsequent stacked PRs.

Expected-output fixture changes

  • Files changed: none.
  • Why the new expected output is correct: focused unit coverage exercises the new positive and negative boundaries.

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow
mstykow force-pushed the fix/contactless-chained-action-credits branch from 696f267 to 7ad8719 Compare September 3, 2026 11:06
@mstykow

mstykow commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai review

@mstykow
mstykow merged commit 87c752d into main Sep 3, 2026
12 checks passed
@mstykow
mstykow deleted the fix/contactless-chained-action-credits branch September 3, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant