Skip to content

feat(donate-page-button): add button that navigates to donate page#193

Merged
maxktz merged 1 commit into
getpaykit:mainfrom
Muhammad-Owais-Warsi:donate-button
May 30, 2026
Merged

feat(donate-page-button): add button that navigates to donate page#193
maxktz merged 1 commit into
getpaykit:mainfrom
Muhammad-Owais-Warsi:donate-button

Conversation

@Muhammad-Owais-Warsi
Copy link
Copy Markdown
Contributor

@Muhammad-Owais-Warsi Muhammad-Owais-Warsi commented May 30, 2026

closes: #192

Summary by CodeRabbit

  • New Features
    • Added a "Donate" link to the desktop navigation dropdown menu, allowing users convenient access to donation options directly from the main navigation interface.

Review Change Stack

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

@Muhammad-Owais-Warsi is attempting to deploy a commit to the maxktz Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

📝 Walkthrough

Walkthrough

A new external "Donate" link is added to the NavigationBar component's desktop dropdown menu. The link points to /donate and is inserted before the existing llms.txt entry in the dropdownLinks array.

Changes

Navigation Donate Link

Layer / File(s) Summary
Add Donate link to dropdown
apps/web/src/components/layout/navigation-bar.tsx
A new "Donate" entry is added to the dropdownLinks array, positioning it in the desktop navigation dropdown before the llms.txt link.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 A donate link hops into view,
In the nav dropdown, fresh and new,
One line of kindness, placed just right,
For generous hearts to see and click bright! 💝

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'feat(donate-page-button): add button that navigates to donate page' accurately describes the main change: adding a donate link to the navigation bar dropdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/web/src/components/layout/navigation-bar.tsx (1)

60-60: ⚡ Quick win

Consider removing external: true for internal route.

The /donate route is an internal Next.js page (confirmed by the route definition in the codebase), even though it redirects to an external URL. Marking it as external: true will:

  • Open the link in a new tab via target="_blank"
  • Display an ExternalLink icon in the mobile menu

This may be misleading since users see "Donate" as a navigation item rather than an external resource. Internal routes like / and /docs in navTabs don't use the external flag. Consider whether same-tab navigation would provide a cleaner UX for this redirect page.

♻️ Proposed change
-  {name: "Donate", href: "/donate", external: true},
+  { name: "Donate", href: "/donate" },
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/components/layout/navigation-bar.tsx` at line 60, The "Donate"
nav item in navTabs is incorrectly marked external (object {name: "Donate",
href: "/donate", external: true}), which forces target="_blank" and an
ExternalLink icon; remove the external: true flag from that object so it behaves
like other internal routes (same-tab navigation and no external icon). Locate
the navTabs/array or the entry with name "Donate" in navigation-bar.tsx, delete
the external property, and verify the link rendering logic (mobile and desktop)
treats it as an internal link (no target="_blank" and no ExternalLink icon).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/web/src/components/layout/navigation-bar.tsx`:
- Line 60: The "Donate" nav item in navTabs is incorrectly marked external
(object {name: "Donate", href: "/donate", external: true}), which forces
target="_blank" and an ExternalLink icon; remove the external: true flag from
that object so it behaves like other internal routes (same-tab navigation and no
external icon). Locate the navTabs/array or the entry with name "Donate" in
navigation-bar.tsx, delete the external property, and verify the link rendering
logic (mobile and desktop) treats it as an internal link (no target="_blank" and
no ExternalLink icon).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cc72aac9-224f-4c71-a717-3f7775a59154

📥 Commits

Reviewing files that changed from the base of the PR and between a574f4e and bfd9c94.

📒 Files selected for processing (1)
  • apps/web/src/components/layout/navigation-bar.tsx

@maxktz
Copy link
Copy Markdown
Contributor

maxktz commented May 30, 2026

thank you!

@maxktz maxktz merged commit d70525c into getpaykit:main May 30, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a button which redirects to donate page

2 participants