feat(donate-page-button): add button that navigates to donate page#193
Conversation
|
@Muhammad-Owais-Warsi is attempting to deploy a commit to the maxktz Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughA new external "Donate" link is added to the NavigationBar component's desktop dropdown menu. The link points to ChangesNavigation Donate Link
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/src/components/layout/navigation-bar.tsx (1)
60-60: ⚡ Quick winConsider removing
external: truefor internal route.The
/donateroute is an internal Next.js page (confirmed by the route definition in the codebase), even though it redirects to an external URL. Marking it asexternal: truewill:
- Open the link in a new tab via
target="_blank"- Display an ExternalLink icon in the mobile menu
This may be misleading since users see "Donate" as a navigation item rather than an external resource. Internal routes like
/and/docsinnavTabsdon't use theexternalflag. Consider whether same-tab navigation would provide a cleaner UX for this redirect page.♻️ Proposed change
- {name: "Donate", href: "/donate", external: true}, + { name: "Donate", href: "/donate" },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/components/layout/navigation-bar.tsx` at line 60, The "Donate" nav item in navTabs is incorrectly marked external (object {name: "Donate", href: "/donate", external: true}), which forces target="_blank" and an ExternalLink icon; remove the external: true flag from that object so it behaves like other internal routes (same-tab navigation and no external icon). Locate the navTabs/array or the entry with name "Donate" in navigation-bar.tsx, delete the external property, and verify the link rendering logic (mobile and desktop) treats it as an internal link (no target="_blank" and no ExternalLink icon).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/web/src/components/layout/navigation-bar.tsx`:
- Line 60: The "Donate" nav item in navTabs is incorrectly marked external
(object {name: "Donate", href: "/donate", external: true}), which forces
target="_blank" and an ExternalLink icon; remove the external: true flag from
that object so it behaves like other internal routes (same-tab navigation and no
external icon). Locate the navTabs/array or the entry with name "Donate" in
navigation-bar.tsx, delete the external property, and verify the link rendering
logic (mobile and desktop) treats it as an internal link (no target="_blank" and
no ExternalLink icon).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cc72aac9-224f-4c71-a717-3f7775a59154
📒 Files selected for processing (1)
apps/web/src/components/layout/navigation-bar.tsx
|
thank you! |
closes: #192
Summary by CodeRabbit