Repository navigation
perf: make agent tunnel and HTTP/2 windows configurable - #4662
Merged
Merged
Conversation
- Add agentTunnelStreamWindowMb and http2ReceiveWindowMb settings - Apply them to the agent tunnel stream window and the HTTP/2 server receive window - Add a Tunnel settings page - Remove settings propagation to remote agents, including the timeout sync worker
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Show the HTTP/2 receive window and stream window fields on the tunnel tab only when the environment reports them - Rename buffer window i18n keys to buffer_windows and value_in_mib - Parse the mux window capability as uint32 before clamping to 1-64 MiB - Set the SSE write timeout to one hour - Add codec tests for pooled and fallback mux data decoding - Reformat test table literals to one field per line
Member
Author
|
Note 🤖 Claude Opus 5.5 responding on behalf of Kyle Mendell @greptileai review |
greptile-apps
Bot
dismissed
their stale review
November 5, 2026 20:51
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchm.*())What This PR Implements
Makes the agent tunnel and manager HTTP/2 receive windows configurable, and moves environment settings from manager-pushed to per-environment.
Fixes: No issue linked yet.
Changes Made
MuxData(pkg/agent/tunnel.go).http2ReceiveWindowMbsets the manager's HTTP/2 receive window. Default is 32 MiB per stream and 64 MiB per connection, up from 8 and 16 MiB.agentTunnelStreamWindowMbsets the agent tunnel stream window. The tunnel client and server both read it./settings/tunnelpage. The HTTP/2 window is labelled manager only.PropagatedKeys(), and thepropagatetag are gone. Timeouts, build provider, builds directory, build timeout, Depot project, and Trivy resource limits are now edited per environment.Testing Done
just format all: cleangolangci-lintonbootstrapandsettings: 0 issuessettings,bootstrap(including app startup wiring),config/schema,agent, andimageupdatecheckand lint passNot verified:
just lint alland the full test suite. These are left to CI.AI Tool Used (if applicable)
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.
The PR appears safe to merge; no actionable issue remains.Summary
Makes tunnel windows configurable and removes manager-to-agent settings pushes.
Reviews (3) · Last reviewed commit: "fix: bound mux window capability parse t..." · Reviewed by Greptile