Skip to content

Tier rail 4/4: remove glassSize, glass drawing and glass terminology after consumers migrate #159

Closed

Description

@cchacs

Effort: M

Part of #131 (remediation step 8). Last: depends on Tier rail 1-3 and on the Section Map consumer migration (feedBack-plugin-sectionmap#14).

The glasses are being retired, not restyled. Once no consumer reads the v2 presentation fields, delete the old surface.

Scope

  • Remove glassSize / fillPercentage from the v2 emit path, or retire v2 entirely, following the transition policy decided in Tier rail 1/4.
  • Remove the glass drawing helpers and tier-to-glass presentation code (screen.js ~1165-1215) and the old canvas HUD.
  • Remove glass terminology from plugin.json's description, README.md (~L128-160), INTEGRATION.md and COMPLIANCE.md.
  • Bump plugin.json and update CHANGELOG.md; note the contract removal as a breaking change for any third-party consumer.

Acceptance criteria

  • No remaining references to glasses (git grep -i glass is empty apart from the changelog).
  • Verified Section Map (with sectionmap#14 merged) still renders from the v3 payload with this plugin at the new version, and still works with Difficulty Ladder absent.
  • The contract tests from sub-issue 1 are updated to drop the v2 cases.

Out of scope

Anything that re-adds presentation fields to the event.

Activity

  1. pullfrog commented on Oct 2, 2026

    @pullfrog
    Contributor
  2. cchacs commented on Oct 7, 2026

    @cchacs
    CollaboratorAuthor

    Status: Blocked-external
    Track: Cross-repo
    Milestone: M6 Cross-repo & Final Removal
    Blocked by: #157 + sectionmap#14 consumer migration
    Agent/session: unclaimed

    Exit check: git grep -i glass clean outside the changelog.

    Sequenced per the repository's issue-sequencing plan (milestones M1-M6, ordered; this comment is the Status/Track/Blocked-by coordination line while the board is milestones-only). Update this comment when claiming, blocking, or handing off - claim protocol: one agent per issue; comment Claimed in <branch> (<milestone>); branch naming m<M>-<issue>-<slug>; set Status to In Progress/In Review/Done here as work proceeds. Never take this issue as a work item if Track is meta.

  3. pullfrog commented on Oct 17, 2026

    @pullfrog
    Contributor

    Implemented #159 and opened PR #231 (pullfrog/159-remove-glass → main).

    Done: Retired the v2 section-difficulty surface (v2 constants/payload, difficulty:sections-updated event, the legacy canvas glass HUD, and the showGlasses forward-migration); the v3 event is now the sole contract. Scrubbed glass terminology from all docs, dropped the v2 tests and pinned the v3 payload keys — node --test 419/419 pass and git grep -i glass returns only CHANGELOG.md. plugin.json bumped to 0.41.0 with a CHANGELOG entry.

    Gate: sectionmap#14 is still open upstream, so PR #231 must not merge until it lands — stated in the PR body and the CHANGELOG/MIGRATION wording. This is the one remaining acceptance criterion I could not verify (external repo).

    Pullfrog  | View workflow run | via Pullfrog | Using big-pickle (free) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Track: Cross-repomulti-repository integrations and removalsenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions