Repository navigation
fix(keys_highway_3d): keep run score across hand-filter changes - #146
Merged
Merged
Conversation
_setHandFilter() rebuilt playable and called _resetScoring(), wiping hits/misses/streak whenever the hand filter changed mid-song (reachable from Split Screen's per-panel popover). Judged-note keys are (t, midi)- keyed so they stay valid across the rebuild and the miss sweep only runs over the visible playable, so only the sweep cursor is re-anchored — mirroring the mastery path from #129. Fixes #130
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by free · Input: 221.3K · Output: 2.9K · Cached: 293.8K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
_setHandFilter() rebuilt playable and called _resetScoring(), wiping hits/misses/streak whenever Both/LH/RH changed mid-song (reachable from Split Screen's per-panel popover, so the posted stats covered only the time since the change).
Judged-note keys are (t, midi)-keyed so they stay valid across the rebuild, and the miss sweep only runs over the visible playable (a hidden-hand note can never accrue a miss while hidden) — so only the sweep cursor is re-anchored, mirroring the mastery path from #129. Also corrects the now-stale _anchorMissSweep comment that still described the reset behavior.