Repository navigation
docs: document the real 2–6 panel range, seven main-window layouts, and the narrower pop-out set - #76
Merged
cchacs merged 1 commit intoOct 1, 2026
Conversation
The README still led with "2–4 highway panels" and "Five layouts" after the five/six grids landed, and that stale summary is what dropped the four→six increase from the v1.14.20 notes (splitscreen#71). - README leads with 2–6 synchronized panels and lists all seven main-window layouts, describing Five as 2-over-3 and Six as 3×2 - State explicitly that a pop-out window's layout set is narrower than the main window's (Single/Top-Bottom/Left-Right/Quad, stopping at Quad) - Correct the Path 2 integration rule and the constitution preamble from 2–4 to 2–6 instances - Fix the same stale count in the surfaces users read first: the plugin.json blurb, the tour's layout-picker step, and the screen.js module header - Add Five and Six to the Settings default-layout picker, which stopped at Quad, so the documented default matches what it can select - Add tests deriving the advertised range, layout count, settings options and both picker option lists from LAYOUTS / FOLLOWER_LAYOUT_PANELS, so a future layout can't ship undocumented
Up to standards ✅🟢 Issues
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Verification notes
Reviewed by free · Input: 0 · Output: 0 · Cached: 0 |
cchacs
deleted the
pullfrog/71-document-six-screen-max-and-seven-layouts
branch
October 1, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the documentation half of #71 (the release-notes half is already published). Left open for review — not merging.
What was stale
At
191fb96,screen.js'sLAYOUTShas seven main-window layouts spanning 2–6 panels, but the README still led with "2–4 highway panels" / "Five layouts", the Path 2 integration rule and the constitution preamble both said 2–4 instances, and the pop-out docs claimed popups get "the same layouts available in main" before listing four of them.Changes
README
.specify/memory/constitution.md— preamble 2–4 → 2–6; version/date footer bumped to 1.4.1 / 2026-10-01.Beyond the issue's list, because the same claim was stale in the surfaces users read first
plugin.json— the plugin-manager blurb read "split into 2–4 synced panels"; the most prominent string in the plugin, and the exact wording the issue named.tour.json— the layout-picker step said "Top/bottom, left/right, or quad (four panels)" while spotlighting#splitscreen-layout-btn, which now contradicts the README. Rewritten to "Seven layouts, from two panels up to six".screen.js— module header comment said "Creates 2-4 independent highway panels".settings.html— the default-layout picker stopped at Quad, so a savedsplitscreenLayoutoffive/sixcouldn't be represented. Added both options. This is the one functional (cosmetic) change here, hence the patch bump to 1.14.22 — the repo'sversion-bumped-on-changecompliance gate counts.js/.htmlas functional source.Drift guard
Five tests in
tests/screen.test.jsderive the advertised surface from the code, so the next layout can't ship undocumented:LAYOUTSprovidesLAYOUTSkeyssettings.htmloptionsLAYOUTSkeyscreateLayoutBtnoptions (hand-written copy ofLAYOUTS)FOLLOWER_LAYOUT_PANELSset + the README's narrower-set claimFOLLOWER_LAYOUT_PANELSentry is silently dead (rebuildFollowerLayoutbails on the unknown key)Each guard was mutation-checked, not just run green: renaming the
FOLLOWER_LAYOUT_PANELSdeclaration, adding a deadsixoption to the pop-out picker, and adding asevenlayout toLAYOUTSwithout touching the docs or pickers each fail loudly (the first one initially passed vacuously viaMath.max()of an empty spread — the parsers now assert a non-empty match first).Test plan
node --check screen.js— cleannode tests/screen.test.js— 187 pass, 0 fail (185 before, +2 net new)Not fixed here
The constitution's Principles IV, VI and VIII still reference the retired
createJumpingTabPane/createTabViewfactories andjumpingTabPane.resize()(stale since splitscreen#47), and its Governance section still namestopkoa/slopsmith-plugin-splitscreen. AlsoCLAUDE.md:46listslayoutas only'top-bottom' | 'left-right' | 'quad', andCLAUDE.md:30describesLAYOUTSas{ panels, style }when the grid layouts addcols/rows. Separate pass — flagging rather than bundling, since those are architecture-doc claims rather than the capacity summary this issue is about.big-pickle(free) | 𝕏