[cchacs]

Summary

_smUpdate() bailed out on "no sections" (empty array / missing duration) before touching any state, so switching to a song or arrangement with no section data (a GP import, or a core re-stream that bypasses the playSong wrapper's own _smRemove()/reset — e.g. an in-player arrangement switch) left the previous song's blocks painted and the marker/active-highlight frozen wherever the last real song left them.

Now clears _smSections/_smDuration/the bar's innerHTML/cached DOM refs the first time sections disappear, and is a no-op on every later tick once already cleared (clearing is idempotent, so no risk of rebuilding an empty bar every 200ms while genuinely no song is loaded).

Test plan

• node --test tests/screen.test.js — 22 passed (1 new test simulating a song switch to one with no sections, without going through _smRemove() — asserts the bar's innerHTML is cleared and state is reset)

🤖 Generated with Claude Code

https://claude.ai/code/session_01HVxQShyx8Mrqe1GKNstjHy

---

Generated by Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 176f365e-7e88-4ea8-9158-17f7da473468

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pullfrog]

Important

The clear is gated on _smSections.length > 0, but the song:ready listener empties _smSections without clearing the rendered bar — and the host fires song:ready on exactly the arrangement switches / re-streams this fix targets. See the inline comment for the ordering that still leaves the stale bar painted.

Reviewed changes

• plugin.json — version bumped 1.2.5 → 1.2.6 for the user-visible fix.
• screen.js — _smUpdate() now clears _smSections/_smDuration, the bar's innerHTML, and the cached _smMarkerEl/_smBlockEls/_smActiveIdx on the first tick where the current song has no section data, then no-ops on subsequent ticks. Side benefit worth keeping: resetting _smDuration to 0 also makes click/wheel seeking no-ops on a section-less song.
• tests/screen.test.js — new test asserting the bar clears and state resets when sections vanish mid-play without going through _smRemove(), plus a no-op re-tick assertion; suite passes 22/22.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Big Pickle (free) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes

• screen.js — re-anchored the stale-bar clear on _smBar.innerHTML !== '' instead of _smSections.length > 0, so it fires on the song:ready path where the handler zeroes _smSections before its own _smUpdate() call (the exact ordering the prior review flagged); also cleared _smSectionDifficulty in the same block for parity with the playSong wrapper and song:ready reset sites.
• tests/screen.test.js — added a regression test reproducing the song:ready ordering (sections already [], stale bar DOM/refs still live). Verified it fails against the previous commit's guard and passes on the current code. Suite passes 23/23.
• plugin.json — version bumped 1.2.6 → 1.2.7 (net 1.2.5 → 1.2.7 from base).

  ^{｜ View workflow run ｜ Using Big Pickle (free) ｜ 𝕏}