Repository navigation
Keybinds 4/4: remove the document-level key listener and verify the help panel #40
Description
Part of #10. Last: depends on Keybinds 2/4 and 3/4.
Scope
- Remove the now-empty
onKeyDowndocument-level listener (or keep only branches that genuinely cannot be shortcuts, and say why). - Verify in the running app that every editor shortcut appears in the
?help panel with a sensible description and scope. - Update
CLAUDE.md/docs if they describe the old listener.
Acceptance criteria
- No hardcoded
document-level shortcut handling remains for the keys covered by Hardcoded keybinds in onKeyDown bypass window.registerShortcut #10. - The
?panel lists the editor's shortcuts. - The editor's existing keyboard tests still pass.
Out of scope
New shortcuts.
Activity
pullfrog commentedon Oct 2, 2026
pullfrog commentedon Oct 9, 2026
Implemented #39 (register Space/Escape with the Host shortcut service) as the prerequisite for #40, reduced
onKeyDownto the gates that cannot be shortcuts plus an inert fallback that stands down once the registry is active, and extendedtests/keybind_registration.test.mjs. A self-review caught four real issues (Space key-token mismatch, other Escape owners left unguarded, a dropped parts-view guard, and no no-double-handling test) — all fixed.node --test400 pass, eslint 0 errors. PR: #66 (closes #39, #40).Task list (2/9 completed)
big-pickle(free) ｜ 𝕏refactor(input): split _editorEscape into rung helpers for CodeFactor…
feat(editor): register Space/Escape with the host shortcut service (#39…
refactor(input): split _editorEscape into rung helpers for CodeFactor…