Skip to content

Restore plain machine headers in environment picker - #3578

Merged
ymichael merged 1 commit into
mainfrom
bb/investigate-picker-menu-regression-thr_6hdfdh2d88
Sep 12, 2026
Merged

ymichael merged 1 commit into
mainfrom
bb/investigate-picker-menu-regression-thr_6hdfdh2d88

Conversation

@ymichael

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

#3274 replaced plain machine names in the environment picker headers with MachineLabel, adding a tiny laptop icon beside every machine name, including servers and desktop machines.

What changed

Restore the previous status-dot-and-name header markup. Preserve name truncation and the conditional “this machine” badge. Update the existing picker test to assert that headers contain no laptop icon.

How you verified

  • pnpm exec turbo run test --filter=@bb/app -- EnvironmentPicker.test.tsx — all 31 tests passed, including the “this machine” badge assertion.
  • Captured and visually inspected the actual picker in Ladle with fixture machines, both with and without local-daemon detection. Headers have no laptop icons; the local fixture shows the badge. Screenshot animations were disabled for stable captures.
  • git diff --check passed.

AGENT GENERATED

@ymichael
ymichael merged commit 1668bd8 into main Sep 12, 2026
16 checks passed
@ymichael
ymichael deleted the bb/investigate-picker-menu-regression-thr_6hdfdh2d88 branch September 12, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant