Conversation
ymichael
force-pushed
the
bb/fixer-deliver-machine-variables-to-normal-reposi-thr_7xicu7evcb
branch
from
September 12, 2026 03:33
ba58b58 to
209411a
Compare
ymichael
force-pushed
the
bb/fixer-deliver-machine-variables-to-normal-reposi-thr_7xicu7evcb
branch
from
September 12, 2026 03:38
209411a to
c6313e5
Compare
ymichael
deleted the
bb/fixer-deliver-machine-variables-to-normal-reposi-thr_7xicu7evcb
branch
September 12, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Variables saved in Machine environment were omitted from ordinary repository setup. A script needing a configured token could fail even though BB had saved the value correctly. The machine-environment support in PR #3274 supplied explicit hooks, but normal setup ran through
environment.attachwithout those values.What changed
Resolve fresh machine variables on the server when dispatching setup, then pass them transiently through
environment.attachinto the existing setup runner. The retained provisioning request stays free of plaintext values. Existing encryption, precedence, cancellation and recovery behavior remain; unmanaged attached paths still skip setup.Adds the validated attach contribution field and bumps host-daemon protocol 204 → 205, requiring older daemons to update. Updates the configuration documentation, machine CLI guide and bb-cli reference. No new user-facing setting or CLI command.
How you verified
@bb/server,@bb/host-daemonand@bb/host-daemon-contract; formatting and diff checks passed.pnpm start:worktree, configured Modal, and created a test thread through the BB CLI. A real Modal sandbox installed this server’s daemon, cloned a disposable repository, and ran ordinary setup. Setup required a configured test variable and wrote a receipt; the live Codex thread read the receipt and returned PASS. The initial byte comparison omitted the receipt’s trailing newline; the corrected check passed without changing the file.Focused commands: