Measure inline chat drop targets within the pane - #3483
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The inline chat column lacked a split-drag target marker. Sidebar drags therefore measured the whole main workspace, including the secondary panel, and classified the visible chat center as a left-edge split when that panel was open.
Reproduction report
What changed
Use the existing pane context ID on the inline main-content element. Center drops retain replacement behavior. The change is contained to the secondary-panel UI: 113 added/deleted text lines across 2 files (110 test lines, 3 production lines).
How you verified
Replace this chat, receivedSplit left.pnpm exec turbo run test --filter=@bb/app -- src/components/secondary-panel/SecondaryPanelLayout src/components/sidebar/useThreadRowSplitDrag.test.tsx src/lib/split-drag src/views/thread-detail/SplitThreadArea: 98 tests passed across 8 files after the fix.pnpm exec turbo run typecheck --filter=@bb/apppassed;git diff --checkpassed; no binary changes.Fixes #3481