Fix SDK response method dispatch for host installer events - #3468
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Fix SDK response method dispatch for host installer events#3468bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The SDK invoked the global Response prototype method on a transport-owned native response. Hono's server adapter replaces that prototype with a method requiring adapter-private state, causing installer event reads to throw. Reproduction and root-cause report.
What changed
Read through the returned response's own text method, with a local Response annotation to widen Hono's inferred return type. Add a regression test for a native response under a replaced global constructor, including multiple events, CRLF, and blank lines. No public contract changes. Total: 52 changed text lines (50 additions, 2 deletions), two SDK files.
How you verified
pnpm exec turbo run test typecheck build --filter=@bb/sdk: passed; all 105 tests pass.git diff --checkclean; no binary changes.Fixes #3466