Split Provider Usage footer test by behavior - #3458
Merged
ymichael merged 1 commit intoSep 11, 2026
Merged
Conversation
ymichael
deleted the
bb/ci-flake-fix-provider-usage-disclosure-timeout-thr_fggkemwuzp
branch
September 11, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The Provider Usage footer coverage put plugin import/registration, the content-script preload and focus listener lifecycle, disclosure rendering, two Radix machine-menu sessions, provider mouse and keyboard navigation, disconnected state, dismiss, manual refresh, and disposal inside one asynchronous test with the default 5-second budget. Package-shard concurrency and Vitest worker oversubscription made that serial UI sequence slow enough to expose the test architecture: the unchanged test reproduced at 6.610 seconds under bounded Intel contention and timed out at 5 seconds. The CI failure was therefore not a deterministic regression in PR #3449, and scheduler contention was the trigger rather than the root cause.
What changed
plugins/provider-usage/app.test.tsxnow loads and captures the plugin registration once outside test clocks, reuses one response fixture, and divides coverage into registration, content-script focus refresh, disconnected/manual refresh, and connected machine/provider interaction scenarios. Content-script disposal is protected byfinally. The disconnected case starts from the active Intel machine, removing a second Radix menu lifecycle while the connected case still proves all machines are aggregated and exercises machine selection plus provider mouse and keyboard navigation. No assertions were disabled, no timeout was increased, and there are no wire, CLI, or documentation changes.How you verified
host_nwqfteeqz4, a warmed run with 12 bounded CPU competitors reproduced the exact failure: 6.610 seconds andTest timed out in 5000ms.pnpm exec turbo run test --filter=bb-plugin-provider-usage— 3 files and 7 tests passed.pnpm exec turbo run typecheck --filter=bb-plugin-provider-usage— passed.pnpm exec turbo run build --filter=bb-plugin-provider-usage— passed the package's available upstream generator tasks; this package has no build script.bb plugin buildfromplugins/provider-usage— emitted validated server and app bundles.