Keep command-palette guidance visible while navigating - #2877
Closed
brsbl wants to merge 17 commits into
Closed
Conversation
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…-v4-thr_ccffp4w2p2' into bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
…o bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
brsbl
force-pushed
the
bb/command-palette-persistent-guidance-v4-thr_ccffp4w2p2
branch
from
September 9, 2026 20:28
aabc9dd to
68c157f
Compare
brsbl
force-pushed
the
bb/command-palette-thread-search-v4-thr_ccffp4w2p2
branch
from
September 9, 2026 20:28
b875f10 to
60f481e
Compare
brsbl
removed this pull request from stack #2879
September 10, 2026 02:56
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Keyboard guidance disappeared or detached from the result viewport. Dialog-level clipping also cut off the scope menu on short result lists, so clicking the clipped Archived option could dismiss the palette.
What changed
Startup-size allowance
Increase only the raw
maxBootBytesbudget by 2,048 bytes (about 0.12%), from 1,723,617 to 1,725,665, for the persistent shell/guidance. The synchronized main budget was exceeded by 1.3 KiB at this layer and 1.6 KiB at the hierarchy layer. The 419.0 KiB compressed budget, forbidden dependency gates, and route-closure budgets remain unchanged. Final-head CI passes the budget checks.No public or wire contracts changed. Lower-priority prototype/abstraction cleanup remains follow-up work, not an additional review-driven expansion.
Screenshots
Captured 2026-09-09 in the isolated branch web app, Chrome for Testing 153.0.8010.36, light theme, 1440×900 at DPR 1. Same dev database, synthetic archived reference, installed plugins, and
/settings/keyboardroute throughout.origin/mainadvanced to4ed274321after the rebase onto0b4115aa9; current-main comparison is intentionally separate from the exact layer baseline.Current origin/main versus this PR
4ed27432168c157fdfExact layer baseline —
60f481e2aThese are the matching before images from the parent PR head. The exact-head images above are the after images for this layer.
Historical evidence from before the rebase
The following captures retain their original source revisions. They document earlier implementation and bug verification, not the current PR head.
Exact branch web app, same synthetic threads, active-thread route, query “Archived design reference”, light theme, and 1440×900 viewport in Chrome for Testing 153.0.8010.36.
Before — exact parent head
b875f102bAfter — reviewed pre-rebase head
aabc9dd13After — entire scope menu remains visible on a one-result list
Historical bug evidence — pre-fix
539a14ef5This earlier capture uses the prior “Palette unsent draft” fixture on Keyboard settings. It demonstrates the original clipping; it is not the paired exact-parent comparison above.
How you verified
BB-Thread-ID: thr_ccffp4w2p2