Skip to content

Add optional learnable node identity features - #131

Merged
cornelislouisa merged 1 commit into
mainfrom
louisa/learnable-gene-identity
Sep 11, 2026
Merged

Add optional learnable node identity features#131
cornelislouisa merged 1 commit into
mainfrom
louisa/learnable-gene-identity

Conversation

@cornelislouisa

Copy link
Copy Markdown
Collaborator

Summary

  • Add gene_identity=learnable, backed by one trainable embedding per shared node.
  • Inject identity before the existing feature encoder and message-passing layers using concatenation (default) or projected addition.
  • Adjust graph and flat encoder dimensions, validate fixed shared node order, and keep the feature independent of k-fold splitting and external GenePT data.

This is stacked on #130, which itself follows #128 and #127. No k-fold, GenePT, OV, generated-results, or local experiment files are included.

Test plan

  • Focused gene-identity tests (11 passed)
  • Hydra composition with gene_identity=learnable
  • Full pytest suite (158 passed)
  • Pre-commit hooks pass

Base automatically changed from louisa/smoking-dataset-clean to main September 11, 2026 18:04
Append or add a trainable embedding for each node before feature encoding and
message passing. Keep the feature independent of k-fold splitting and external
GenePT data, with focused tests for graph and flat encoders.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cornelislouisa
cornelislouisa force-pushed the louisa/learnable-gene-identity branch from 9868b7c to 95a12ee Compare September 11, 2026 18:10
@cornelislouisa
cornelislouisa merged commit 3a6f5a9 into main Sep 11, 2026
3 checks passed
@cornelislouisa
cornelislouisa deleted the louisa/learnable-gene-identity branch September 11, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants