Track citation copy clicks before clipboard write#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cite_copyandcite_urlGTM dataLayer events before attempting clipboard writes.Why
Live testing on
/resources/00000157c02249ae81ad7ee1300d3586_0showed both copy clicks can fail withNotAllowedError: Failed to execute 'writeText' on 'Clipboard': Write permission denied.Because the GTM push was afterwriteText, those clicks never reached GTM Preview.Validation
npm test -- --run src/__tests__/components/resource/CitationTable.test.tsxnpx eslint src/components/resource/CitationTable.tsx src/__tests__/components/resource/CitationTable.test.tsxnpx prettier --check src/components/resource/CitationTable.tsx src/__tests__/components/resource/CitationTable.test.tsxgit diff --checkNote: ESLint/Prettier emitted the local pyenv rehash warning but exited successfully.