Fix Leaflet IIIF image viewer#299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iiif_imageresources through the Leaflet viewer instead of synthesizing a Mirador manifest.abcdefgeoimplementation.info.json, compute native zoom, buildL.CRS.Simpleimage bounds from pixel dimensions, constrain panning with padded max bounds, and refit on layout changes.Why
IIIF Image API resources need Leaflet's simple image coordinate space, not geospatial basemap coordinates. The earlier fix selected
CRS.Simple, but it still relied onleaflet-iiiflifecycle behavior and did not compute the image bounds frominfo.jsonbefore fitting/constraining the map. That led to rough panning/zooming behavior and impossible tile requests.Impact
Image-service-only IIIF resources can render as bounded image maps with predictable zoom and pan behavior, while IIIF Presentation manifests continue to use Mirador and normal geospatial Leaflet resources continue through the GeoBlacklight path.
Validation
npm test -- run src/__tests__/geoblacklight/leaflet_viewer_controller.test.js src/__tests__/components/resource/ResourceViewer.test.tsxnpm run build