Skip to content

feat(fees): move the open-bucket cascade carve into GenVM ✨ - #53

Open
kp2pml30 wants to merge 1 commit into
v0.2-devfrom
pr/v0.2/feat/open-bucket-carve
Open

kp2pml30 wants to merge 1 commit into
v0.2-devfrom
pr/v0.2/feat/open-bucket-carve

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Auto-opened executor mirror of genlayerlabs/genvm-manager#68.

Carries the executor-side work for that manager PR. The manager branch update fast-forwards v0.2-dev to its pinned commit after landing.

Summary by CodeRabbit

  • New Features
    • Message fee cascading now ensures post-message and contract deployment fees meet the configured minimum. When eligible internal messages are present, they also receive an equal share of half the remaining budget. No share is added when there are no internal messages, the fees meet or exceed the budget, or the calculated share is zero.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: genlayerlabs/genvm-executor/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 43f8d003-41fa-4b8c-b385-6f115bc9b417
📥 Commits

Reviewing files that changed from the base of the PR and between 7cba87e and 262995b.

⛔ Files ignored due to path filters: 1
  • executor/src/rt/cascade_test.rs is excluded by !**/*_test.rs
📒 Files selected for processing: 3
  • executor/src/lib.rs
  • executor/src/rt/cascade.rs
  • executor/src/rt/mod.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The executor now applies an optional message fee cascade to emissions after a run succeeds. The cascade raises selected fees to a minimum and distributes part of the remaining budget among internal messages.

Changes: Message fee cascade

Layer / File(s) Summary
Cascade fee calculation
executor/src/rt/cascade.rs, executor/src/rt/mod.rs
The new public cascade module floors PostMessage and DeployContract fees, then distributes half of the remaining budget equally across internal messages when the stated conditions allow.
Apply cascade after successful run
executor/src/lib.rs
run_with_impl retains the optional cascade and applies it to run emissions after spawn_apply_run succeeds. Run errors still propagate without cascade application.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 26299

No confirmed issue blocks merging. The intended precedence between minimum fees and the cascade budget remains unclear.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: moving the open-bucket cascade carve into GenVM. It matches the added cascade application logic and executor integration.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant