Repository navigation
fix(consensus): guard against zero total stake in VRF validator selection - #1793
Closed
HusseinAdeiza wants to merge 2 commits into
Closed
HusseinAdeiza wants to merge 2 commits into
HusseinAdeiza wants to merge 2 commits into
Conversation
…tion get_validators_for_transaction divided each validator's stake by the total stake without checking for zero. When all validators have stake=0 (e.g. internally-created validators in protocol_rpc/endpoints.py), this raised ZeroDivisionError and crashed the consensus worker, halting transaction processing. Fall back to a uniform probability distribution when the total stake is zero; non-zero totals are unaffected. Adds a unit test covering the zero-stake path. Closes genlayerlabs#1732 Signed-off-by: HusseinAdeiza <HusseinAdeiza@users.noreply.github.com>
Contributor
|
This PR targeted I retargeted it to |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 22
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1732.
get_validators_for_transactiondivided each validator's stake by the total stake with no zero check. When all validators havestake=0(e.g. the internally-created validators inprotocol_rpc/endpoints.py), this raisedZeroDivisionErrorand crashed the consensus worker, halting transaction processing.Change
Fall back to a uniform probability distribution when
total_stake == 0; non-zero totals are unaffected. Adds a unit test (test_get_validators_for_transaction_all_zero_stake) covering the zero-stake path.Testing
vrf↔basecircular import prevents importingvrffirst, on pristinemaintoo): zero-stake →[1/3,1/3,1/3], normal stakes →[1/6,2/6,3/6], mixed → stake weights.Note: the diff shows
.github/workflows/*deletions only because the contributor PAT lacksworkflowscope; no workflow behavior is changed by this PR.Summary by CodeRabbit