Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/protocol_rpc/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ def fund_account(
if normalized_amount <= 0:
raise InvalidParams(message="amount must be a positive integer")

account_address = eth_utils.to_checksum_address(account_address)

import secrets

nonce = transactions_processor.get_transaction_count(None)
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_simulator_sessions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1114,3 +1114,42 @@ def transactions_processor_factory(s):
new_status=TransactionStatus.FINALIZED,
update_current_status_changes=True,
)


def test_fund_account_normalizes_lowercase_address(monkeypatch):
session = MagicMock()
accounts_manager_instance = MagicMock()
accounts_manager_instance.is_valid_address.return_value = True

transactions_processor_instance = MagicMock()
transactions_processor_instance.get_transaction_count.return_value = 5
transactions_processor_instance.insert_transaction.return_value = None

def mock_token_hex(n):
return "def" if n == 32 else "xxx"

monkeypatch.setattr("secrets.token_hex", mock_token_hex)

monkeypatch.setattr(
endpoints,
"AccountsManager",
lambda s: accounts_manager_instance if s is session else None,
)
monkeypatch.setattr(
endpoints,
"TransactionsProcessor",
lambda s: transactions_processor_instance if s is session else None,
)

lowercase = "0x" + "ab" * 20
result = endpoints.fund_account(session, lowercase, 100)

assert result == "0xdef"
checksummed = "0xABaBaBaBABabABabAbAbABAbABabababaBaBABaB"
transactions_processor_instance.insert_transaction.assert_called_once_with(
None, checksummed, None, 100, 0, 5, False, 0, None, "0xdef"
)
accounts_manager_instance.credit_tx_value_once.assert_called_once_with(
"0xdef", checksummed, 100
)
session.commit.assert_called_once()
Loading