[Alicepoltora]

Problem

initialize_validators() compares a hash of the desired validators JSON against a hash of the DB state, and only performs the destructive delete-all/recreate cycle when the config has actually changed (per its own docstring).

However, both _current_config_hash() and _desired_config_hash() build their hash keys from (provider, model, stake, amount) only — config, plugin, and plugin_config are ignored entirely.

Consequence

Any change to validator settings that does not touch provider/model/stake — e.g. rotating an API URL, changing plugin options, editing config — produces the same hash, so reinitialization is silently skipped and validators keep running with stale provider configuration indefinitely.

Reproduction

# hash with old api_url
old = _desired_config_hash(
    '[{"stake":100,"provider":"openai","model":"gpt-4",'
    '"plugin":"openai","plugin_config":{"api_url":"https://api.old.example"}}]'
)
# hash with new api_url — must differ, but was identical before this fix
new = _desired_config_hash(
    '[{"stake":100,"provider":"openai","model":"gpt-4",'
    '"plugin":"openai","plugin_config":{"api_url":"https://api.new.example"}}]'
)
assert old != new  # FAILED before this fix

The added test test_initialize_validators_reinitializes_when_plugin_config_changed fails on main and passes with this fix.

Fix

Both hash functions now key on (provider, model, stake, config, plugin, plugin_config), with config/plugin_config canonically serialized (json.dumps(..., sort_keys=True)).

Tests

• tests/unit/test_validators_init.py: 13 passed, incl. 2 new tests:
  • test_initialize_validators_reinitializes_when_plugin_config_changed — regression test (fails without the fix)
  • test_config_hash_equal_when_only_config_present_on_both_sides — ensures identical full configs still skip reinit

Summary by CodeRabbit

• Bug Fixes

  • Validator updates now detect changes to provider settings, API URLs, models, plugins, and plugin options.
  • Validators are automatically reinitialized when their configuration changes.
  • Unchanged validator configurations no longer trigger unnecessary reinitialization.

• Tests

  • Added coverage for configuration changes that require validator replacement.
  • Added coverage confirming identical configurations are preserved without replacement.

[github-actions]

This PR targeted main, which is only the default/static branch.

I retargeted it to v0.123-dev, the active development branch. Pushes to v0.123-dev automatically fast-forward main.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4d8ac600-104c-4d08-89bb-73cd85c98500

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}