Repository navigation
chore: add nix cache - #1719
chore: add nix cache#1719
Conversation
|
This PR targeted I retargeted it to |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.dockerignore:
- Line 12: Update the root .dockerignore rules to allow traversal of the docker/
directory before the existing negation rule for
docker/genvm-source-build.nix.conf, ensuring that Docker root-context builds can
include this file for the COPY in Dockerfile.backend.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9024c4cd-fb9c-4f5d-a551-42a5ab7a5c61
📒 Files selected for processing (4)
.dockerignore.github/actions/genvm-runners-closure/action.ymldocker/Dockerfile.backenddocker/genvm-source-build.nix.conf
0a8c1db to
ac50f20
Compare
| - name: Install Nix | ||
| uses: cachix/install-nix-action@b4b293eae0b79aac8a161bb32925a5508c9cca93 # v31 | ||
| id: nix | ||
| uses: genlayerlabs/github-actions/nix-setup@main |
There was a problem hiding this comment.
our own repo + required approval for merge = no need for SHA in my opinion
MuncleUscles
left a comment
There was a problem hiding this comment.
The BuildKit secret approach and Compose/Bake mapping are sound, and unauthenticated cache fallback behaves as intended. I’m requesting changes for three remaining issues: the credential-handling action is mutable, the source-mode path is not exercised by CI at this commit, and the local closure prebuild does not consume the new cache configuration.
9153684 to
fb3bf50
Compare
MuncleUscles
left a comment
There was a problem hiding this comment.
Re-reviewed the latest head. The shared action is now pinned to an immutable SHA, and the source-mode binding exercises the closure prebuild and credential-forwarded Docker build successfully in CI. The Nix daemon trust-boundary explanation also resolves the local-host configuration concern. No blocking findings.
fb3bf50 to
8b06e7e
Compare
Adds a nix cache for genvm source builds + a config with retries / fallbacks for it
Summary by CodeRabbit