Skip to content

chore: add nix cache - #1719

Merged
kp2pml30 merged 2 commits into
v0.123-devfrom
chore/add-nix-cache
Aug 4, 2026
Merged

kp2pml30 merged 2 commits into
v0.123-devfrom
chore/add-nix-cache

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Aug 1, 2026 •

Copy link
Copy Markdown
Member

Adds a nix cache for genvm source builds + a config with retries / fallbacks for it

Summary by CodeRabbit

  • Build Improvements
    • Improved container build reliability with configured download retries, timeouts, and local-build fallback behavior.
    • Enabled use of the GenLayer binary cache to speed up supported builds.
    • Centralized source-build configuration for more consistent build settings.
    • Ensured required build configuration is included in Docker build contexts.

@github-actions
github-actions Bot changed the base branch from main to v0.123-dev August 1, 2026 09:21
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

This PR targeted main, which is only the default/static branch.

I retargeted it to v0.123-dev, the active development branch. Pushes to v0.123-dev automatically fast-forward main.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 83e95d1d-3330-4e9d-a8ed-0cd41e0d17aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.dockerignore:
- Line 12: Update the root .dockerignore rules to allow traversal of the docker/
directory before the existing negation rule for
docker/genvm-source-build.nix.conf, ensuring that Docker root-context builds can
include this file for the COPY in Dockerfile.backend.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9024c4cd-fb9c-4f5d-a551-42a5ab7a5c61

📥 Commits

Reviewing files that changed from the base of the PR and between c427b1d and 0a8c1db.

📒 Files selected for processing (4)
  • .dockerignore
  • .github/actions/genvm-runners-closure/action.yml
  • docker/Dockerfile.backend
  • docker/genvm-source-build.nix.conf

Comment thread .dockerignore
@kp2pml30
kp2pml30 force-pushed the chore/add-nix-cache branch from 0a8c1db to ac50f20 Compare August 3, 2026 09:08
- name: Install Nix
uses: cachix/install-nix-action@b4b293eae0b79aac8a161bb32925a5508c9cca93 # v31
id: nix
uses: genlayerlabs/github-actions/nix-setup@main

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our own repo + required approval for merge = no need for SHA in my opinion

@kp2pml30
kp2pml30 requested a review from MuncleUscles August 3, 2026 11:24

@MuncleUscles MuncleUscles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BuildKit secret approach and Compose/Bake mapping are sound, and unauthenticated cache fallback behaves as intended. I’m requesting changes for three remaining issues: the credential-handling action is mutable, the source-mode path is not exercised by CI at this commit, and the local closure prebuild does not consume the new cache configuration.

Comment thread .github/actions/genvm-runners-closure/action.yml Outdated
Comment thread .github/workflows/backend_integration_tests_pr.yml
Comment thread .env.example
@kp2pml30 kp2pml30 self-assigned this Aug 4, 2026
@kp2pml30
kp2pml30 force-pushed the chore/add-nix-cache branch from 9153684 to fb3bf50 Compare August 4, 2026 08:42

@MuncleUscles MuncleUscles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the latest head. The shared action is now pinned to an immutable SHA, and the source-mode binding exercises the closure prebuild and credential-forwarded Docker build successfully in CI. The Nix daemon trust-boundary explanation also resolves the local-host configuration concern. No blocking findings.

@kp2pml30 kp2pml30 removed the run-tests label Aug 4, 2026
@kp2pml30
kp2pml30 force-pushed the chore/add-nix-cache branch from fb3bf50 to 8b06e7e Compare August 4, 2026 09:27
@kp2pml30
kp2pml30 merged commit 0a30401 into v0.123-dev Aug 4, 2026
15 of 16 checks passed
@kp2pml30
kp2pml30 deleted the chore/add-nix-cache branch August 4, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants