Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231
What
numOfInitialValidatorsfrom the authoritative transaction returned by the existinggetTransactionAllDatacallinitialRotationsas an alias for the validator countWhy
Bradbury's projected
getTransactionDataresponse does not includenumOfInitialValidators. The SDK currently substitutesinitialRotations, but these are independent protocol values. As a result, a transaction created with five validators and zero rotations is reported as having zero validators, which makes committee diagnostics and monitoring inaccurate.The full transaction is already fetched in parallel, so this fix uses its stored validator count without adding an RPC request.
Testing done
npm test -- --run— 78 tests passed, no type errorsnpm run build— ESM, CJS, and declaration builds passednpx eslint src/transactions/actions.ts src/transactions/decoders.ts src/types/transactions.ts tests/transactions.test.tsnumOfInitialValidators: "5"git diff --checkDecisions made
getTransactionAllData().numOfInitialValidatorsvalue is preferred because it is the actual validator count; the projected value remains a compatibility fallback.initialRotationsremains represented in the raw type, but is no longer used as a validator-count alias.Checks
Reviewing tips
The functional change is the single merge field in
getTransaction; the decoder change removes the incorrect semantic alias. The parameterized test demonstrates that changing rotations does not change the reported validator count.User facing release notes
getTransaction()now reports the correct initial validator count on Bradbury instead of substituting the leader-rotation setting.