Skip to content

Update role journey onboarding#842

Merged
JoaquinBN merged 1 commit into
devfrom
JoaquinBN/journey-role-start
Jun 26, 2026
Merged

Update role journey onboarding#842
JoaquinBN merged 1 commit into
devfrom
JoaquinBN/journey-role-start

Conversation

@JoaquinBN

@JoaquinBN JoaquinBN commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Starts a newly selected role journey immediately after profile setup and sends the user directly into that journey. Replaces the old journey notice strip with a shared welcome header across Builder, Community, and Validator journey views. Keeps Community journey social-link steps in sync after X or Discord OAuth, hides builder welcome markers from profile recent contributions, and removes the unused notice component.

Summary by CodeRabbit

  • New Features
    • Added a new welcome header for journey pages with personalized messages, progress chips, and alerts.
    • Updated onboarding to start the selected journey immediately after profile completion.
  • Bug Fixes
    • Improved journey progress tracking so completed steps update right away after account linking.
    • Hid specific contribution items from recent activity while keeping the displayed count consistent.
  • Refactor
    • Replaced the older notice-style journey header across builder, community, and waitlist pages with the new welcome experience.

@JoaquinBN JoaquinBN merged commit 9a0218a into dev Jun 26, 2026
2 of 3 checks passed
@JoaquinBN JoaquinBN deleted the JoaquinBN/journey-role-start branch June 26, 2026 15:43
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ef757fbd-1425-42a1-b30b-c6312f0a87fc

📥 Commits

Reviewing files that changed from the base of the PR and between a70ce4d and 7a95053.

📒 Files selected for processing (7)
  • frontend/src/components/ProfileCompletionGuard.svelte
  • frontend/src/components/funnel/journeys/JourneyNotice.svelte
  • frontend/src/components/funnel/journeys/JourneyWelcome.svelte
  • frontend/src/components/profile/ProfileRecentContributions.svelte
  • frontend/src/routes/BuilderJourney.svelte
  • frontend/src/routes/CommunityJourney.svelte
  • frontend/src/routes/ValidatorWaitlist.svelte

📝 Walkthrough

Walkthrough

The PR replaces the journey notice header with a shared JourneyWelcome component across builder, community, and validator pages, updates community account-linking state handling, starts the selected journey after profile completion, and filters hidden welcome contributions from recent profile contributions.

Changes

Journey onboarding and completion flow

Layer / File(s) Summary
Shared journey welcome component
frontend/src/components/funnel/journeys/JourneyWelcome.svelte
Adds a welcome header with title, message, alert, and chips props plus responsive styling.
Builder and validator wiring
frontend/src/routes/BuilderJourney.svelte, frontend/src/routes/ValidatorWaitlist.svelte
Replaces JourneyNotice with JourneyWelcome and derives the props passed into the new header on both pages.
Community journey linking
frontend/src/routes/CommunityJourney.svelte
Replaces the header, derives welcome content and progress chips, updates linked-step state, and handles returned user data from social linking.
Profile completion start flow
frontend/src/components/ProfileCompletionGuard.svelte
Starts the selected journey through journeyAPI after profile save, merges returned user data, reloads the store, clears onboarding state, and redirects to journeyPath.
Recent contributions filter
frontend/src/components/profile/ProfileRecentContributions.svelte
Filters hidden contribution slugs from recent contributions and overfetches before trimming to the requested limit.

Sequence Diagram(s)

sequenceDiagram
  participant ProfileCompletionGuard
  participant journeyAPI
  participant userStore
  participant journeyPath

  ProfileCompletionGuard->>journeyAPI: startBuilderJourney() or startRoleJourney(targetRole)
  journeyAPI-->>ProfileCompletionGuard: startRes.data.user
  ProfileCompletionGuard->>userStore: merge returned user and loadUser()
  ProfileCompletionGuard->>journeyPath: redirect(targetRole)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch JoaquinBN/journey-role-start

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant