v4.6.1 - #42
Merged
Merged
v4.6.1#42
Conversation
The aerial phase recomputed magnitude(spinVector) into a cached rw field every integration step, but nothing read it except the getRw() accessor, which had no callers anywhere in the library, tests, examples, or wasm bindings. Remove the field, its calculate method, the two call sites, and the dead getter so the integration loop skips a per-step sqrt.
The aerial phase ends as soon as the ball reaches ground height, so a zero or negative launch angle from ground level (startZ = 0) exits the flight immediately and produces no trajectory. Document the constraint on the launchAngleDeg field and in the how-to guide, and note that putts and ground-level rolls are out of scope.
set(CMAKE_CXX_FLAGS "-Wall -Wextra") discarded any flags the user passed on the command line or in the cache. Prepend the existing value so the warning flags add to user-supplied flags rather than replacing them, matching the append idiom the coverage block already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_CXX_FLAGS