Skip to content

fix(build): drop -ffast-math so NaN convergence guards hold on macOS (4.5.1) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdifiore merged 1 commit into from
May 26, 2026
Merged

fix(build): drop -ffast-math so NaN convergence guards hold on macOS (4.5.1) #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.14)
project(golf VERSION 4.5.0 LANGUAGES CXX)
project(golf VERSION 4.5.1 LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
Expand Down Expand Up @@ -66,7 +66,13 @@ if(MSVC)
else()
# GCC/Clang flags
set(CMAKE_CXX_FLAGS "-Wall -Wextra")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -ffast-math")
# No -ffast-math: it implies -ffinite-math-only, which lets the compiler
# assume NaN/Inf never occur and fold NaN comparisons to a constant. The
# convergence guards (FlightSimulator run loop + *Phase::isPhaseComplete)
# rely on IEEE semantics — `NaN <= height` must stay false so a poisoned
# trajectory never falsely "completes". Apple Clang folded it the other way,
# breaking the hang guards on macOS.
set(CMAKE_CXX_FLAGS_RELEASE "-O3")
endif()

# Code coverage option
Expand Down
Loading