Repository navigation
fix: ナビゲーションのホバーで入力フォーカスを奪わない - #315
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
g-kari
marked this pull request as ready for review
October 24, 2026 18:56
Preserve startup regression coverage and original navigation changes. Remove only the temporary fixed-old-runtime comparison job and its unused config after retaining the RED/GREEN evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final integration verification: passed
Exact head
60a33f0622f0c44eec62a4c3b4d615a4fa6ec600, base2d7cbc59d2c62970fa689fa37cd4b278ef7bbed4, test-merge4b3592d25a4e127cc852a336146e3d7508559b87, identical tree47c0a4bc08fc06c53acf1f1522ec143dc8d5016b.Final coordinator checks for current base/head, protection and reviews are still required. This report is not formal PR approval.
Revalidated navigation integration after #350 (2026-11-06)
Head
60a33f0622f0c44eec62a4c3b4d615a4fa6ec600is a normal non-force merge of the previous PR head and actual main2d7cbc59d2c62970fa689fa37cd4b278ef7bbed4, after #350's post-merge verification completed successfully.No denied #347 changes, React 19 upgrade, dependency changes or approval/protection changes are included. Merge remains pending all fresh results and coordinator checks.
Current diagnostic status (2026-11-06 09:52 UTC)
2026-11-06: diagnostic hook corrected to document input capture
Current head
6e5834676e7b4459b9afd31426c318a9c756a7b0, base29019667; still not merge-ready. Application source is unchanged.The prior selectionchange probe was invalid for this document root: React 18.3.1 skips that registration when the document already has the root listening marker. Both previous A/B failures are retained as phase failures, not functional React reproductions. This diagnostic uses input capture registration with boolean true, then the same single microtask, SSR visible/editable conditions and bounded stack/DOM observations. It remains a timing heuristic with synthetic input, not production-causation proof. The existing locked formatter is also run on only the new public spec via stdin, writing exact formatting to the diagnostic artifact without changing source or hiding the quality failure; that temporary step will be removed when its formatting is adopted. All source, original expectations and guards remain unchanged. New-head CI is pending; the original natural React #345 failure remains unresolved and no rerun has been used.
2026-11-06: phase probe prerequisite correction, still not merge-ready
Current diagnostic head:
03959f0644f07d3d70f82b897d3ca8d4f2e7bfdc, base29019667. Application source remains unchanged.The previous diagnostic head
146be69epassed the ordinary 342 browser cases, 12076 unit cases, Catalog and JSON Lines. Its two temporary A/B jobs instead failed their explicit phase prerequisite (armed=true, triggered=0); they did not reach the SQL assertion and do not establish a React reproduction. Those results and the earlier natural React #345 failure at head6df7cc47remain recorded separately.This commit only holds first-party scripts until the SSR input is visible and empty, enables the one-shot probe, then releases scripts in finally. Bounded registration/microtask observations record URL, document readiness, DOM presence and editable/visible conditions. A missing observation is recorded explicitly without replacing an existing failure, and fails an otherwise passing diagnostic. Additional exact locked public package exports are preserved as text. The same fixed A/B runtime refs, original 342 cases, transport/pageerror guards and individual timeouts are retained. The synthetic phase probe remains diagnostic, not a claim of production reproduction. New-head CI is pending; no source fix or rerun has been applied.
2026-11-06: validation remains blocked, controlled phase comparison
Current head:
146be69e568cb6feafeec49be9a3b192b70e4cb5; base:290196672ec908485b65a0354ab930492e0a2eb5. This PR is not ready to merge.6df7cc47passed 12076 unit cases and 341 browser cases, but one mobile CSV SQL case failed at its first valid input with React chore(deps): update dependency gsap to v3.15.0 #345 and missing SQL output. Navigation 20 and INI 42 passed. This is retained as a real unresolved failure, not retried away.29019667against the failed PR source6df7cc47, overlaying only the same new test and config. Both jobs retain their own failures and upload exact source/digests and the installed locked public startup source. Existing application source, 26 CSV SQL cases, all 342 regular browser cases, and the original shard aggregate are unchanged.isTrusted=false). An explicit 5-second phase assertion is separate from the original 5-second SQL assertion. It is diagnostic evidence, not by itself a production reproduction or proof of the navigation change's cause. No additional input repairs its first action.New-head official CI is pending. Earlier evidence below is historical and does not establish this head's success.
🤖 AI 投稿 (Codex)
最新のmain同期(2026-11-06)
通常PRとして、INI初期入力修正PR349を含む実main
290196672ec908485b65a0354ab930492e0a2eb5を取り込みました。新head6df7cc472f02d035d4d82a7aaa019f64ec18bbee/ tree54326caaa7def35874675ff7162aa6ebde313e75。元head039f33a8を親に残した通常merge commitで、force pushはしていません。同期前main29019667の事後は、全12043unit/322browser/JSONLines9・集約/Workers Build/CodeQLまで成功済みです。新headの最終検証とマージ条件の確認が終わるまでマージ待ちです。
2026-10-19の旧head診断・検証の記録
以下は旧head039f33a8と当時のbaseの記録です。当時のDraft/保留という記述や旧CI成功は、新headの状態を示すものではありません。
目的と修正
Refs Seeder KAZAMI-138。共通ナビゲーションをホバーで開いたとき、入力欄・選択範囲や別のメニューで操作中のリンクからフォーカスを奪わないようにします。現在 main で独立再現してから修正し、PR314 の回帰とは扱いません。readiness 前の入力消失は別件・原因未確定のまま触りません。
独立した未修正 main baseline
Base: ab2830a
診断 head: 331840a / tree 5fa3dbf35071f8e37fba20ebdde61e9ec199ba37
4 test/docs/workflow files だけで、production root blob 46b1bdefad21935cffca9b773293c6ee8816ad71 は main と byte-identical です。
固定修正候補とローカル検証
Head: 039f33a
Tree: 7d05e6775b450b08b5ac3885a1f42ef21a1f1a09
8 files / 対 main patch SHA256: 4fac1d807d96a8e0183527c6f1bdf7b40a4fa273f7e76491dcfa4e2b9425a7db
Remote 作成 tree は独立レビュー対象の local write-tree と完全一致し、branch head / tree を read-back 確認しました。
実 shell / SSR / hydrated app は loopback preview で検証し、route 自身の initial input focus を待ってから入力します。test-driven input focus はせず、page.keyboard で現在の本当の入力先を確認。既存の外部 HTTP / pageerror / hydration guard を維持します。process 全体の egress 隔離、実モバイル端末、screen reader、配備済み production や readiness 前の入力保持は保証しません。
最終 head の通常 hosted 検証(2026-10-19 22:58 UTC)
最終 head 039f33a / tree 7d05e6775b450b08b5ac3885a1f42ef21a1f1a09 の結果です。過去の baseline 失敗と区別しています。
保留
技術検証は上記の最終 head で成功していますが、正当な正式レビュー条件が未充足です。未検証の Ready probe・自己承認・merge・配備は行いません。停止中 K78、disabled workflows、sandbox / mandatory isolation / アクセス制限、本人 PC / Work に触れません。readiness 前の入力消失や元の scroll-specific 条件を解消済みとは扱いません。
最終 source / base bundle / patch / regressions / 失敗 baseline / 最終 hosted logs / native artifacts / screenshots の packet を Library へ保存しました(22405620 bytes / SHA256 84f5ea104ce80a7b24b3d02fdffa190b69789f181e87998ffe3328923f359a9b)。別 file / inode への読戻しで全 bytes、ZIP CRC、重複なし 83 members、全 manifest hashes と変更 8 Git blobs / modes を照合済み。base bundle と patch から 1760 tracked entries を復元し、最終 tree 7d05e677 と完全一致することも確認しました。