Skip to content

fix: ナビゲーションのホバーで入力フォーカスを奪わない - #315

Merged
g-kari merged 8 commits into
mainfrom
fix/nav-hover-focus-20261019
Nov 6, 2026
Merged

g-kari merged 8 commits into
mainfrom
fix/nav-hover-focus-20261019

Conversation

@g-kari

@g-kari g-kari commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Final integration verification: passed

Exact head 60a33f0622f0c44eec62a4c3b4d615a4fa6ec600, base 2d7cbc59d2c62970fa689fa37cd4b278ef7bbed4, test-merge 4b3592d25a4e127cc852a336146e3d7508559b87, identical tree 47c0a4bc08fc06c53acf1f1522ec143dc8d5016b.

  • All 9 checks completed successfully on this head. Format, lint, types, builds and 386 files / 12,079 unit tests passed, including the original navigation 33 and startup 3 unit cases.
  • CSV-family real-app browser: core 189 + generators 159 = 348 unique cases, all single-pass with no retry, skip or flaky results. This includes navigation 20, INI 42, CSV SQL 26 and startup 6, with the controlled root phase armed/triggered once at both widths and correct SQL.
  • Catalog: 66 passed. JSON Lines: 9 passed. The 3 native artifacts were verified for exact size, SHA-256, CRC, checked-out source SHA and case results; CSV-family report union/disjointness was also checked.
  • All new-head runs used attempt 1; no reruns. The removed old-runtime diagnostic failures remain in history and retained evidence. Startup preparation was fixed separately in fix: prepare the server router before document hydration #350 and its exact post-merge source and regressions are retained here.

Final coordinator checks for current base/head, protection and reviews are still required. This report is not formal PR approval.


Revalidated navigation integration after #350 (2026-11-06)

Head 60a33f0622f0c44eec62a4c3b4d615a4fa6ec600 is a normal non-force merge of the previous PR head and actual main 2d7cbc59d2c62970fa689fa37cd4b278ef7bbed4, after #350's post-merge verification completed successfully.

  • Keep the original navigation implementation, config, unit tests and browser tests byte-for-byte. Keep fix: prepare the server router before document hydration #350's startup code, 3 unit tests, 6 browser cases and the identical controlled input spec, plus the INI repair and existing guards.
  • Remove only the temporary fixed-old-runtime A/B diagnostic job and its now-unused standalone config. Their real React chore(deps): update dependency gsap to v3.15.0 #345 failures remain in commit/CI history and retained evidence; this is not reclassification of the old failing source as successful. The same controlled spec now runs on the current startup implementation through the normal startup regression suite.
  • Keep the reviewed Catalog budget adjustment (job 20 minutes, Chromium setup step 10 minutes), without changing browser assertions, per-test timeouts, mirrors, guards or permissions.
  • New-head verification is pending: 12,079 unit tests, core 189 + generators 159 = 348 browser cases, Catalog 66, JSON Lines 9, full checks, exact artifact/source and test-merge tree validation. Old head results are not substituted.

No denied #347 changes, React 19 upgrade, dependency changes or approval/protection changes are included. Merge remains pending all fresh results and coordinator checks.


Current diagnostic status (2026-11-06 09:52 UTC)

  • Latest head 0ab236a applies the exact formatter bytes from both official CI artifacts and removes the five-line formatter observation in the same commit. App source is unchanged. New CI is pending; merging remains on hold.
  • At head6e5834, identical controlled synthetic focus/input during a verified React hydrateRoot listener phase failed on both main2901 and original PR6df7 at both widths: React error345, native CSV preserved, SQL output absent. This is a controlled baseline defect, not proof of the cause of the original natural failure or a navigation regression.
  • Earlier selectionchange phase failures and quality-format stops are retained as diagnostic/format failures, not functional RED. No retry, expectation weakening, or denied YAML347 source was used.

2026-11-06: diagnostic hook corrected to document input capture

Current head 6e5834676e7b4459b9afd31426c318a9c756a7b0, base 29019667; still not merge-ready. Application source is unchanged.

The prior selectionchange probe was invalid for this document root: React 18.3.1 skips that registration when the document already has the root listening marker. Both previous A/B failures are retained as phase failures, not functional React reproductions. This diagnostic uses input capture registration with boolean true, then the same single microtask, SSR visible/editable conditions and bounded stack/DOM observations. It remains a timing heuristic with synthetic input, not production-causation proof. The existing locked formatter is also run on only the new public spec via stdin, writing exact formatting to the diagnostic artifact without changing source or hiding the quality failure; that temporary step will be removed when its formatting is adopted. All source, original expectations and guards remain unchanged. New-head CI is pending; the original natural React #345 failure remains unresolved and no rerun has been used.

2026-11-06: phase probe prerequisite correction, still not merge-ready

Current diagnostic head: 03959f0644f07d3d70f82b897d3ca8d4f2e7bfdc, base 29019667. Application source remains unchanged.

The previous diagnostic head 146be69e passed the ordinary 342 browser cases, 12076 unit cases, Catalog and JSON Lines. Its two temporary A/B jobs instead failed their explicit phase prerequisite (armed=true, triggered=0); they did not reach the SQL assertion and do not establish a React reproduction. Those results and the earlier natural React #345 failure at head 6df7cc47 remain recorded separately.

This commit only holds first-party scripts until the SSR input is visible and empty, enables the one-shot probe, then releases scripts in finally. Bounded registration/microtask observations record URL, document readiness, DOM presence and editable/visible conditions. A missing observation is recorded explicitly without replacing an existing failure, and fails an otherwise passing diagnostic. Additional exact locked public package exports are preserved as text. The same fixed A/B runtime refs, original 342 cases, transport/pageerror guards and individual timeouts are retained. The synthetic phase probe remains diagnostic, not a claim of production reproduction. New-head CI is pending; no source fix or rerun has been applied.

2026-11-06: validation remains blocked, controlled phase comparison

Current head: 146be69e568cb6feafeec49be9a3b192b70e4cb5; base: 290196672ec908485b65a0354ab930492e0a2eb5. This PR is not ready to merge.

  • Previous head 6df7cc47 passed 12076 unit cases and 341 browser cases, but one mobile CSV SQL case failed at its first valid input with React chore(deps): update dependency gsap to v3.15.0 #345 and missing SQL output. Navigation 20 and INI 42 passed. This is retained as a real unresolved failure, not retried away.
  • Catalog's previous run exhausted its existing 10-minute job during slow Chromium APT setup before any browser test. This commit only separates that setup with a 10-minute step cap and a 20-minute overall job; browser expectations, individual test timeouts, guards, mirrors and permissions are unchanged.
  • Temporary diagnostic jobs compare exact main 29019667 against the failed PR source 6df7cc47, overlaying only the same new test and config. Both jobs retain their own failures and upload exact source/digests and the installed locked public startup source. Existing application source, 26 CSV SQL cases, all 342 regular browser cases, and the original shard aggregate are unchanged.
  • The phase probe uses document selectionchange registration as a React 18 timing heuristic and a synthetic input (isTrusted=false). An explicit 5-second phase assertion is separate from the original 5-second SQL assertion. It is diagnostic evidence, not by itself a production reproduction or proof of the navigation change's cause. No additional input repairs its first action.
  • These temporary jobs must be resolved and removed before final merge. Previous failing evidence remains recorded; fix: ハイドレーション前の YAML 変換操作が結果を捨てるのを防ぐ #347's unmerged YAML changes are not included.

New-head official CI is pending. Earlier evidence below is historical and does not establish this head's success.

🤖 AI 投稿 (Codex)

最新のmain同期(2026-11-06)

通常PRとして、INI初期入力修正PR349を含む実main 290196672ec908485b65a0354ab930492e0a2eb5 を取り込みました。新head 6df7cc472f02d035d4d82a7aaa019f64ec18bbee / tree 54326caaa7def35874675ff7162aa6ebde313e75。元head039f33a8を親に残した通常merge commitで、force pushはしていません。

  • 元のnavigation実装・config・33unit・20browserの4blobsは完全一致です。現mainのrootも元featureのbaselineと一致し、変更を落とさず同期しています。
  • 競合するdocs/release notesは両方の追記を保持。既存分割workflowへcore限定navigation1stepとpath各3行だけを追加し、除去すると現main全文に戻ります。
  • INI修正と既存42INI、全322browser、parser/serializer、YAML、手動Renovate、依存/lock、権限、20分job/10分setup、外部通信guard、fail-closed集約を保持。削除済みauto-merge controllerも復活させません。
  • 新headはcore183+generators159=342browser(navigation20+既存322)、全385files/12076unit(navigation33追加)、JSONLines9、build/types、2native artifact/source、全checksを新たに確認中です。旧headの成功は流用しません。
  • 固定8file差分の独立静的レビューはblockingなしですが、正式GitHub approvalや実CI成功とは別です。

同期前main29019667の事後は、全12043unit/322browser/JSONLines9・集約/Workers Build/CodeQLまで成功済みです。新headの最終検証とマージ条件の確認が終わるまでマージ待ちです。

2026-10-19の旧head診断・検証の記録

以下は旧head039f33a8と当時のbaseの記録です。当時のDraft/保留という記述や旧CI成功は、新headの状態を示すものではありません。

目的と修正

Refs Seeder KAZAMI-138。共通ナビゲーションをホバーで開いたとき、入力欄・選択範囲や別のメニューで操作中のリンクからフォーカスを奪わないようにします。現在 main で独立再現してから修正し、PR314 の回帰とは扱いません。readiness 前の入力消失は別件・原因未確定のまま触りません。

  • Hover は表示のみ。カテゴリボタンの Enter / Space / ↓ と明示クリックが最初の実リンクへの focus を要求します。すでに index 0 の hover-open menu でも再起動できます。
  • 矢印・Home / End・Esc・実リンクの Enter と既存の click toggle を保持します。hover-open trigger をクリックすると閉じます。
  • mouseleave の timer をキャンセル・null 化・unmount cleanup し、keyboard focus を持つ menu / trigger を passive timer で消しません。
  • Tab / Shift+Tab は active anchor を先に unmount せず、native の focus 移動後に blur で閉じます。pointer-down / keyup / re-entry 等で古い Tab intent を消し、trigger への pointer focus と後続 click による誤った reopen を防ぎます。
  • README・リリースノート、33 DOM 回帰、20 実 app browser cases を追加。CSS・カテゴリ・routes・依存/lock・認証・配備は変更しません。既存 browser workflow は同等 path filters と限定 step のみで、event 種類・権限・runner・secrets・flags・retry・timeout は不変です。

独立した未修正 main baseline

Base: ab2830a
診断 head: 331840a / tree 5fa3dbf35071f8e37fba20ebdde61e9ec199ba37
4 test/docs/workflow files だけで、production root blob 46b1bdefad21935cffca9b773293c6ee8816ad71 は main と byte-identical です。

  • 実 React の NavCategory を root document 経由で mounted jsdom 実行。最終 33 回帰は未修正 main で 26 failed / 7 passed。
  • mouseenter → isOpen → focusedIndex=0 → anchor.focus() の source / DOM 因果を独立確認しました。jsdom は実スクロール・hit-testing・hydration timing・配備済み production の証明ではありません。
  • 通常 baseline browser run 39335759568: Node 22.23.3 / fresh npm ci、format/lint/types、377 files / 11627 unit、production build、別 full tsc が成功。その後、新 8 browser cases が 6 failed / 2 passed(各 1 attempt、skipped/flaky 0)。後続の既存 browser suites は失敗で未実行です。
  • desktop / narrow の両方で hover が入力の focus、別 category の keyboard link の focus、hover-open trigger の focus を移し、意図した assertion が失敗。両方の Clear probe は成功したため、PR314 で観察した元の scroll-specific 条件そのものは独立再現済みとは扱いません。
  • Native artifact 12227215278: 7567154 bytes / SHA256 8f4272042c0e925e454f41be4184f3627758b0111d0be4a197a52c5bb0338bc0。実 ZIP bytes / CRC / 重複なし、source SHA と native JSON を照合し、先頭 link の focus が見える失敗画像も目視しました。別の 通常 CI 39335759560 と JSON Lines browser も成功しています。
  • 意図した RED unit は初回 test-only commit に入れず、証拠を保持したうえで今回の production 修正 commit に全回帰を含めています。全 unit failure で browser 前段が止まるのを避けた診断手順であり、失敗の削除や成功扱いではありません。

固定修正候補とローカル検証

Head: 039f33a
Tree: 7d05e6775b450b08b5ac3885a1f42ef21a1f1a09
8 files / 対 main patch SHA256: 4fac1d807d96a8e0183527c6f1bdf7b40a4fa273f7e76491dcfa4e2b9425a7db
Remote 作成 tree は独立レビュー対象の local write-tree と完全一致し、branch head / tree を read-back 確認しました。

  • 最終候補の全 378 files / 11660 unit が 1 worker で成功(Node 24.19.0、既存 locked dependencies 再利用、package/lock 不変)。最終 33 回帰、release notes と関連の 96 tests も成功。
  • 対象 8 files の format、対象 5 files の type-aware/type-check lint は 107 rules / 警告・エラー 0。8-file whitespace check 成功。これらは全体 aggregate の成功ではありません。
  • 全体 vp check と standalone tsc は exit 137、production build は client transform 中に exit 1。ローカルで成功とは扱わず、同じ最終 head の通常 hosted CI で確認します。
  • DOM unit は dispatch/timer の返り値を React.act に返さず、実 document root を使います。installed React 18 runtime は DOCUMENT_NODE を受理しますが installed @types Container は Document を省くため、test-only の明示型 bridge を限定使用しています。実装の型を抑制する変更ではありません。
  • 20 browser cases(10 flows × 1280px / 390px)の収集成功。初回 8 assertions に加え hover-open Space/ArrowDown、open menu からの実 native Tab/Shift+Tab、pointer leave timer、click toggle / blur を検証します。timer case は別 menu の実 close を待ち、sleep・retry・timeout 拡大はありません。local Chromium sandbox 拒否の再試行・無効化はしておらず、収集を実行成功とは扱いません。
  • 独立固定差分レビューで source-visible blocker なし。独立 91 関連 tests / 20 browser cases 収集 / patch 照合が成功。独立 tsc も exit 137 で未完。正式な GitHub APPROVED ではありません。

実 shell / SSR / hydrated app は loopback preview で検証し、route 自身の initial input focus を待ってから入力します。test-driven input focus はせず、page.keyboard で現在の本当の入力先を確認。既存の外部 HTTP / pageerror / hydration guard を維持します。process 全体の egress 隔離、実モバイル端末、screen reader、配備済み production や readiness 前の入力保持は保証しません。

最終 head の通常 hosted 検証(2026-10-19 22:58 UTC)

最終 head 039f33a / tree 7d05e6775b450b08b5ac3885a1f42ef21a1f1a09 の結果です。過去の baseline 失敗と区別しています。

  • 通常 CI 39337218437: Node 22.23.3 / fresh npm ci、format 1727、lint/type 1363(警告・エラー 0)、378 files / 11660 tests が成功。通常 synthetic merge 5c1a0b8 は base/head を親に持ち、tree は最終レビュー対象 7d05e677 と完全一致します。
  • 実 app browser 39337218398: 通常 pull_request の attempt 1。全 quality/unit、production build、別 full tsc、新 navigation suite と全既存 6 suites が成功。
  • native JSON 7 reports は 176 / 176 passed(navigation 20 + component 57 + URL 20 + Base64 3 + CSV SQL 20 + XML/JSON 21 + YAML/JSON 35)。skipped / unexpected / flaky は全て 0、全 case が 1 attempt で passed。新 navigation は desktop 10 + narrow 10 = 20 / 20 で、入力・選択範囲・次の文字、hover-open 3 key 起動、実 native Tab / Shift+Tab、timer、click toggle、実リンク navigation を検証しました。
  • 最終 native artifact 12228011551: 5672345 bytes / SHA256 7d51f2902a6ab06ac3f660434c522ab6ce80c8dcfbf72a435af4ce7fafbc5460。実 bytes / ZIP CRC / 重複なしと source SHA、全 reports を照合。
  • 1280px / 390px の success screenshots を目視し、hover menu が表示されても入力の focus ring と次の文字入力が保持されることを確認しました。既存 menu の視覚的な重なりや CSS は変更していません。狭い viewport は実携帯端末や screen reader、配備済み production の証明ではありません。
  • Catalog search 39337218412 は native JSON 66 / 66、JSON Lines 39337218464 も成功。両 native artifacts の SHA / CRC / source SHA を照合しました。
  • 最終 head の可視 check runs 8 件は全て success、CodeRabbit commit status も success。auto-merge check や CodeRabbit status の success は承認・merge を意味しません。
  • 最終 submitted GitHub reviews / inline threads は空です。独立技術レビューは正式 APPROVED ではないため Draft を維持し、Ready / merge / 配備は行っていません。

保留

技術検証は上記の最終 head で成功していますが、正当な正式レビュー条件が未充足です。未検証の Ready probe・自己承認・merge・配備は行いません。停止中 K78、disabled workflows、sandbox / mandatory isolation / アクセス制限、本人 PC / Work に触れません。readiness 前の入力消失や元の scroll-specific 条件を解消済みとは扱いません。

最終 source / base bundle / patch / regressions / 失敗 baseline / 最終 hosted logs / native artifacts / screenshots の packet を Library へ保存しました(22405620 bytes / SHA256 84f5ea104ce80a7b24b3d02fdffa190b69789f181e87998ffe3328923f359a9b)。別 file / inode への読戻しで全 bytes、ZIP CRC、重複なし 83 members、全 manifest hashes と変更 8 Git blobs / modes を照合済み。base bundle と patch から 1760 tracked entries を復元し、最終 tree 7d05e677 と完全一致することも確認しました。

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@g-kari g-kari changed the title test: 共通ナビゲーションのホバーで入力フォーカスが移る問題を独立再現 fix: ナビゲーションのホバーで入力フォーカスを奪わない Oct 19, 2026
@g-kari
g-kari marked this pull request as ready for review October 24, 2026 18:56
Preserve startup regression coverage and original navigation changes. Remove only the temporary fixed-old-runtime comparison job and its unused config after retaining the RED/GREEN evidence.
@g-kari
g-kari merged commit 4ee3d59 into main Nov 6, 2026
10 checks passed
@g-kari
g-kari deleted the fix/nav-hover-focus-20261019 branch November 6, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant