Repository navigation
refactor: 로티 바닥 코드 제거 (로티는 창으로만) - #183
Merged
Merged
Conversation
floor-rottie.mjs를 rottie-cli.mjs로 줄여 창·시니어 탭·adopt가 함께 쓰는 함수만 남기고 바닥 전용 코드(rottieFloor, sendRottieText, buildRottieFloorCreateArgv 등)를 지운다. KADAN_FLOOR=rottie는 KADAN_FLOOR_INVALID. 옛 원장 floor:rottie 줄은 그대로 읽힌다. docs/watch-overview.md에 #181 D1(원장에 있는 요청 ID 우선) 예외를 더한다. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
로티는 바닥으로 쓰지 않고 창(
KADAN_WINDOW=rottie)으로만 쓴다(운영 start 1,404건이 모두floor=tmux). 안 쓰는 로티 바닥 코드가 창 코드와 섞여 읽히는 문제를 없앤다.변경
KADAN_FLOOR=rottie→KADAN_FLOOR_INVALID(tmux|herdr만 허용)src/floor-rottie.mjs→git mv로src/rottie-cli.mjs, 공유 함수만 남김buildRottieFloorCreateArgv추적 결과src/floor-rottie.mjs옛create()(바닥 전용)만 호출했고,cli.mjs는 시험용으로 다시 내보내기만 했다. 창은buildRottieCreateArgv(floor-tmuxopenWindow)를 쓴다. → 바닥 전용이라 삭제.KADAN_WINDOW=rottie시작 경로는 영향 없음.남긴 공유 코드
ROTTIE_CLI_VERBS,assertRottieArgvsrc/rottie-cli.mjsrunRottie,rottieBin(내부),RottieFloorErrorparseRottieCreateEvidence지운 것:
rottieFloor,sendRottieText,buildRottieSendArgv,buildRottieFloorCreateArgv, create/alive/pid/read/send/stop/list/waitForChange/lastStartFor/terminalIdFor.분기 정리
floorName==="rottie"(대신forceWindow, 종료 시 창 닫기 점검은 KADAN_WINDOW와 무관하게 유지)KADAN_WINDOW/choice.kind==="rottie"분기, handover,inspectRottieStartPreflightKADAN_FLOOR제안은 init/quickstart/autostart에 rottie 없음, live-floor-guard는 바닥 이름 분기 없음, gui는 창 설정 표시뿐 → 변경 없음floor:"rottie"줄:tests/floor-rottie-removed.test.mjs로 log·status 확인(읽는 곳은panePid ?? rottiePid유지)시험 분류
rottie-list(바닥 list 전용),rottie-floor의 send argv·붙여넣기 Enter 시험(바닥 전용)rottie-floor→floor-common(가짜 바닥 공용 가드, create 응답 해석),rottie-preflight,rottie-connectivity,rottie-stop-path,window-setting,stop-window,restore,adopt-*,assertRottieArgv(senior-tab)KADAN_FLOOR=rottie거절, 옛 원장 줄문서
README, CONTRIBUTING, docs/{design,architecture,commands,kadan-guide.html,senior,card-worktime}. 창 설명은 그대로. D1(#181): docs/watch-overview.md에 "원장에 있는 요청 ID 명시 시 우선" 예외 추가.
검증
격리
npm test1959/1959,check:public0. CI 결과는 아래 확인.🤖 Generated with Claude Code