Projeto incompleto semana2 backend - #46
Open
Augustoluna wants to merge 1 commit into
Open
Augustoluna wants to merge 1 commit into
Augustoluna wants to merge 1 commit into
Conversation
MateusGesualdo
approved these changes
Jan 21, 2021
MateusGesualdo
left a comment
MateusGesualdo
left a comment
There was a problem hiding this comment.
Seu projeto está dentro do esperado, Augusto =)
O que foi feito está correto, atenção apenas para a lógica de atualizar dados do usuário
(o query builder facilita essa funcionalidade, caso queira dar uma pesquisada).
Outras sugestões de melhoria:
- Usar a comparação estrita (
===no lugar de==) - Ser mais específico nas mensagens de erro (exemplo: 'preencha todos os campos corretamente' -> quais?)
- Em
getUserById, retornarresult[0][0]no lugar deresultAo usar oraw, para não enviar os metadados do MySql para o front
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POR FAVOR, EDITE ESSA MENSAGEM INSERINDO AS INFORMAÇÕES DO SEU PROJETO. COMECE APAGANDO ESSA LINHA.
INSIRA O NOME NOME DO PROJETO AQUI
O que funciona
O que não funciona
Link Surge
A PARTIR DA SEMANA 5, INSIRA AQUI O LINK DO SURGE. ANTES DISSO, APAGUE ESSAS DUAS LINHAS.
Imagens
TIRE PRINTS DAS TELAS DO SEU SITE E COLE AQUI